Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1825283006: Clean up analyzer_cli build mode tests. (Closed)

Created:
4 years, 9 months ago by Paul Berry
Modified:
4 years, 9 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Clean up analyzer_cli build mode tests. - Properly convert relative to absolute paths when the command-line arguments are of the form "$uri|$path". - Test the behavior of "--build-suppress-exit-code". R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/014cfddea0f2aa2b7bb22bae5b5f94d9deb58b4f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -12 lines) Patch
M pkg/analyzer_cli/test/driver_test.dart View 3 chunks +42 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 9 months ago (2016-03-23 04:21:44 UTC) #2
scheglov
LGTM
4 years, 9 months ago (2016-03-23 04:24:42 UTC) #3
Paul Berry
4 years, 9 months ago (2016-03-23 04:25:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
014cfddea0f2aa2b7bb22bae5b5f94d9deb58b4f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698