Clean up analyzer_cli build mode tests.

pkg/analyzer_cli/test/driver_test.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer_cli.test.driver;
 
 import 'dart:io';
 
 import 'package:analyzer/plugin/options.dart';
 import 'package:analyzer/source/analysis_options_provider.dart';
@@ skipping 268 matching lines @@
           // Should not be made fatal by `--fatal-warnings`.
           expect(outSink.toString(),
               contains("[warning] The function 'baz' is not defined"));
           expect(outSink.toString(), contains("1 error and 1 warning found."));
         });
       });
     });
 
     group('build-mode', () {
       // Shared driver command.
-      var testFilePath = path.join(
-          path.dirname(Platform.script.toFilePath()), 'data', 'test_file.dart');
-      var doDrive = () => drive('file:///test_file.dart|$testFilePath',
-          args: [
-            '--dart-sdk',
-            findSdkDirForSummaries(),
-            '--build-mode',
-            '--machine'
-          ],
-          options: 'data/options_tests_project/.analysis_options');
+      void doDrive(String filePath, {List<String> additionalArgs: const []}) {
+        drive('file:///test_file.dart|$filePath',
+            args: [
+              '--dart-sdk',
+              findSdkDirForSummaries(),
+              '--build-mode',
+              '--machine'
+            ]..addAll(additionalArgs),
+            options: 'data/options_tests_project/.analysis_options');
+      }
 
       test('no stats', () {
-        doDrive();
+        doDrive('data/test_file.dart');
         // Should not print stat summary.
         expect(outSink.toString(), isEmpty);
         expect(errorSink.toString(), isEmpty);
         expect(exitCode, 0);
       });
+
+      test(
+          'Fails if file not found, even when --build-suppress-exit-code is given',
+          () {
+        doDrive('data/non_existent_file.dart',
+            additionalArgs: ['--build-suppress-exit-code']);
+        expect(exitCode, isNot(0));
+      });
+
+      test('Fails if there are errors', () {
+        doDrive('data/file_with_error.dart');
+        expect(exitCode, isNot(0));
+      });
+
+      test(
+          'Succeeds if there are errors, when --build-suppress-exit-code is given',
+          () {
+        doDrive('data/file_with_error.dart',
+            additionalArgs: ['--build-suppress-exit-code']);
+        expect(exitCode, 0);
+      });
     });
 
 //TODO(pq): fix to be bot-friendly (sdk#25258).
 //    group('in temp directory', () {
 //      Directory savedCurrentDirectory;
 //      Directory tempDir;
 //      setUp(() {
 //        // Call base setUp.
 //        _setUp();
 //        savedCurrentDirectory = Directory.current;
@@ skipping 54 matching lines @@
 }
 
 const emptyOptionsFile = 'data/empty_options.yaml';
 
 /// Shared driver.
 Driver driver;
 
 List<ErrorProcessor> get processors =>
     driver.context.getConfigurationData(CONFIGURED_ERROR_PROCESSORS);
 
+/// Convert a file specification from a relative path to an absolute path.
+/// Handles the case where the file specification is of the form "$uri|$path".
+String adjustFileSpec(String fileSpec) {
+  int uriPrefixLength = fileSpec.indexOf('|') + 1;
+  String uriPrefix = fileSpec.substring(0, uriPrefixLength);
+  String relativePath = fileSpec.substring(uriPrefixLength);
+  return '$uriPrefix${path.join(testDirectory, relativePath)}';
+}
+
 /// Start a driver for the given [source], optionally providing additional
 /// [args] and an [options] file path.  The value of [options] defaults to
 /// an empty options file to avoid unwanted configuration from an otherwise
 /// discovered options file.
 void drive(String source,
     {String options: emptyOptionsFile, List<String> args: const <String>[]}) {
   driver = new Driver();
   var cmd = [
     '--options',
     path.join(testDirectory, options),
-    path.join(testDirectory, source)
+    adjustFileSpec(source)
   ]..addAll(args);
   driver.start(cmd);
 }
 
 /// Try to find a appropriate directory to pass to "--dart-sdk" that will
 /// allow summaries to be found.
 String findSdkDirForSummaries() {
   Set<String> triedDirectories = new Set<String>();
   bool isSuitable(String sdkDir) {
     triedDirectories.add(sdkDir);
@@ skipping 73 matching lines @@
     this.options = options;
   }
 }
 
 class TestSource implements Source {
   TestSource();
 
   @override
   noSuchMethod(Invocation invocation) => super.noSuchMethod(invocation);
 }