Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

Issue 1825213002: DevTools: make sure scope variables do not throw exception (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 747 matching lines...) Expand 10 before | Expand all | Expand 10 after
758 758
759 var fromLine = functionUILocation.lineNumber; 759 var fromLine = functionUILocation.lineNumber;
760 var fromColumn = functionUILocation.columnNumber; 760 var fromColumn = functionUILocation.columnNumber;
761 var toLine = executionUILocation.lineNumber; 761 var toLine = executionUILocation.lineNumber;
762 762
763 // Make sure we have a chance to update all existing widgets. 763 // Make sure we have a chance to update all existing widgets.
764 if (this._valueWidgets) { 764 if (this._valueWidgets) {
765 for (var line of this._valueWidgets.keys()) 765 for (var line of this._valueWidgets.keys())
766 toLine = Math.max(toLine, line + 1); 766 toLine = Math.max(toLine, line + 1);
767 } 767 }
768 if (fromLine >= toLine || toLine - fromLine > 500) { 768 if (fromLine >= toLine || toLine - fromLine > 500 || fromLine < 0 || toL ine >= this.textEditor.linesCount) {
769 this._clearValueWidgets(); 769 this._clearValueWidgets();
770 return; 770 return;
771 } 771 }
772 772
773 var valuesMap = new Map(); 773 var valuesMap = new Map();
774 for (var property of properties) 774 for (var property of properties)
775 valuesMap.set(property.name, property.value); 775 valuesMap.set(property.name, property.value);
776 776
777 /** @type {!Map.<number, !Set<string>>} */ 777 /** @type {!Map.<number, !Set<string>>} */
778 var namesPerLine = new Map(); 778 var namesPerLine = new Map();
(...skipping 350 matching lines...) Expand 10 before | Expand all | Expand 10 after
1129 this.uiSourceCode().removeEventListener(WebInspector.UISourceCode.Events .WorkingCopyChanged, this._workingCopyChanged, this); 1129 this.uiSourceCode().removeEventListener(WebInspector.UISourceCode.Events .WorkingCopyChanged, this._workingCopyChanged, this);
1130 this.uiSourceCode().removeEventListener(WebInspector.UISourceCode.Events .WorkingCopyCommitted, this._workingCopyCommitted, this); 1130 this.uiSourceCode().removeEventListener(WebInspector.UISourceCode.Events .WorkingCopyCommitted, this._workingCopyCommitted, this);
1131 this.uiSourceCode().removeEventListener(WebInspector.UISourceCode.Events .TitleChanged, this._showBlackboxInfobarIfNeeded, this); 1131 this.uiSourceCode().removeEventListener(WebInspector.UISourceCode.Events .TitleChanged, this._showBlackboxInfobarIfNeeded, this);
1132 WebInspector.moduleSetting("skipStackFramesPattern").removeChangeListene r(this._showBlackboxInfobarIfNeeded, this); 1132 WebInspector.moduleSetting("skipStackFramesPattern").removeChangeListene r(this._showBlackboxInfobarIfNeeded, this);
1133 WebInspector.moduleSetting("skipContentScripts").removeChangeListener(th is._showBlackboxInfobarIfNeeded, this); 1133 WebInspector.moduleSetting("skipContentScripts").removeChangeListener(th is._showBlackboxInfobarIfNeeded, this);
1134 WebInspector.UISourceCodeFrame.prototype.dispose.call(this); 1134 WebInspector.UISourceCodeFrame.prototype.dispose.call(this);
1135 }, 1135 },
1136 1136
1137 __proto__: WebInspector.UISourceCodeFrame.prototype 1137 __proto__: WebInspector.UISourceCodeFrame.prototype
1138 } 1138 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698