Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1825213002: DevTools: make sure scope variables do not throw exception (Closed)

Created:
4 years, 9 months ago by lushnikov
Modified:
4 years, 9 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: make sure scope variables do not throw exception BUG=597023 R=dgozman, pfeldman Committed: https://crrev.com/c2a3e10c10bc83130d3aeb970114a2c644749b1b Cr-Commit-Position: refs/heads/master@{#382709}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
lushnikov
ptal
4 years, 9 months ago (2016-03-22 20:36:46 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825213002/1
4 years, 9 months ago (2016-03-22 20:37:20 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-22 22:10:38 UTC) #5
dgozman
lgtm
4 years, 9 months ago (2016-03-22 22:15:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825213002/1
4 years, 9 months ago (2016-03-22 22:15:39 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-22 22:20:49 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 22:22:18 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c2a3e10c10bc83130d3aeb970114a2c644749b1b
Cr-Commit-Position: refs/heads/master@{#382709}

Powered by Google App Engine
This is Rietveld 408576698