Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1825133002: [Autofill] Ignore address nickname and other address naming fields. (Closed)

Created:
4 years, 9 months ago by sebsg
Modified:
4 years, 9 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, rouslan+autofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, bondd+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Some forms have "Address Nickname" or "Address Label" fields that are used to identify an address. These fields were filled as address line 1. Added a regex to find those specific fields and not fill them. BUG=596913 TEST=FormStructureBrowserTest Committed: https://crrev.com/477a7e9549f46f1e7aa30e4e55da85cb08be264b Cr-Commit-Position: refs/heads/master@{#382851}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+374 lines, -4 lines) Patch
A chrome/test/data/autofill/heuristics/input/146_checkout_store.scholastic.com.html View 1 chunk +355 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/100_checkout_costco.com.out View 1 chunk +3 lines, -3 lines 0 comments Download
A chrome/test/data/autofill/heuristics/output/146_checkout_store.scholastic.com.out View 1 chunk +12 lines, -0 lines 0 comments Download
M components/autofill/core/browser/address_field.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/autofill/core/browser/autofill_regex_constants.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_regex_constants.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
sebsg
Could you please take a look at this CL when you get the chance? Thanks!
4 years, 9 months ago (2016-03-22 18:31:08 UTC) #3
sebsg
Could you please take a look at this CL when you get the chance? Thanks!
4 years, 9 months ago (2016-03-22 22:29:30 UTC) #5
vabr (Chromium)
LGTM! Cheers, Vaclav
4 years, 9 months ago (2016-03-23 08:38:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825133002/1
4 years, 9 months ago (2016-03-23 15:41:48 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-23 15:46:59 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 15:48:12 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/477a7e9549f46f1e7aa30e4e55da85cb08be264b
Cr-Commit-Position: refs/heads/master@{#382851}

Powered by Google App Engine
This is Rietveld 408576698