components/autofill/core/browser/address_field.cc - Issue 1825133002: [Autofill] Ignore address nickname and other address naming fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/address_field.cc

Issue 1825133002: [Autofill] Ignore address nickname and other address naming fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/autofill/heuristics/output/146_checkout_store.scholastic.com.out ('k') | components/autofill/core/browser/autofill_regex_constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/address_field.cc

diff --git a/components/autofill/core/browser/address_field.cc b/components/autofill/core/browser/address_field.cc

index de54d6bd8202e1dbbf17b7fd8f594007520ce0c5..3b705a82e3674534a1d90384ecbc56ae8b065748 100644

--- a/components/autofill/core/browser/address_field.cc

+++ b/components/autofill/core/browser/address_field.cc

@@ -58,7 +58,8 @@ scoped_ptr<FormField> AddressField::Parse(AutofillScanner* scanner) {

while (!scanner->IsEnd()) {

const size_t cursor = scanner->SaveCursor();

// Ignore "Address Lookup" field. http://crbug.com/427622

- if (ParseField(scanner, base::UTF8ToUTF16(kAddressLookupRe), NULL)) {

+ if (ParseField(scanner, base::UTF8ToUTF16(kAddressLookupRe), NULL) ||

+ ParseField(scanner, base::UTF8ToUTF16(kAddressNameIgnoredRe), NULL)) {

continue;

} else if (address_field->ParseAddressLines(scanner) ||

address_field->ParseCityStateZipCode(scanner) ||