Issue 18251004: Introduce isHTMLAreaElement and toHTMLAreaElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18251004: Introduce isHTMLAreaElement and toHTMLAreaElement (Closed)

Created:
7 years, 5 months ago by kangil_

Modified:
7 years, 5 months ago

Reviewers:
tkent, jochen (gone - plz use gerrit)

CC:
blink-reviews, aboxhall, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, dmazzoni, adamk+blink_chromium.org, jchaffraix+rendering

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

Introduce isHTMLAreaElement and toHTMLAreaElement To avoid direct use of static_cast, this patch introduces isHTMLAreaElement and toHTMLAreaElement for code cleanup. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153738

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -19 lines)			Patch
M	Source/WebKit/chromium/src/DOMUtilitiesPrivate.cpp	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	Source/core/accessibility/AXObjectCache.cpp	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/core/accessibility/AccessibilityRenderObject.cpp	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/html/HTMLAreaElement.h	View	1 chunk	+16 lines, -0 lines	0 comments	Download
M	Source/core/html/HTMLMapElement.cpp	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/page/FocusController.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/page/SpatialNavigation.cpp	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/rendering/HitTestResult.cpp	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	Source/core/rendering/RenderImage.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kangil.han@samsung.com/18251004/1

7 years, 5 months ago (2013-07-08 13:28:45 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kangil.han@samsung.com/18251004/1

7 years, 5 months ago (2013-07-09 00:27:08 UTC) #3

Message was sent while issue was closed.

Change committed as 153738