Source/core/rendering/HitTestResult.cpp - Issue 18251004: Introduce isHTMLAreaElement and toHTMLAreaElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/HitTestResult.cpp

Issue 18251004: Introduce isHTMLAreaElement and toHTMLAreaElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/HitTestResult.cpp

diff --git a/Source/core/rendering/HitTestResult.cpp b/Source/core/rendering/HitTestResult.cpp

index ec11a7b613698da19404039e27a985903d8ad924..0803f9c90790df61b63aee991a7d094fc6d631e9 100644

--- a/Source/core/rendering/HitTestResult.cpp

+++ b/Source/core/rendering/HitTestResult.cpp

@@ -30,6 +30,7 @@

#include "core/dom/shadow/ShadowRoot.h"

#include "core/editing/FrameSelection.h"

#include "core/html/HTMLAnchorElement.h"

+#include "core/html/HTMLAreaElement.h"

#include "core/html/HTMLImageElement.h"

#include "core/html/HTMLInputElement.h"

#include "core/html/HTMLMediaElement.h"

@@ -324,7 +325,7 @@ KURL HitTestResult::absoluteLinkURL() const

return KURL();

AtomicString urlString;

- if (m_innerURLElement->hasTagName(aTag) || m_innerURLElement->hasTagName(areaTag) || m_innerURLElement->hasTagName(linkTag))

+ if (m_innerURLElement->hasTagName(aTag) || isHTMLAreaElement(m_innerURLElement.get()) || m_innerURLElement->hasTagName(linkTag))

urlString = m_innerURLElement->getAttribute(hrefAttr);

else if (m_innerURLElement->hasTagName(SVGNames::aTag))

urlString = m_innerURLElement->getAttribute(XLinkNames::hrefAttr);

« no previous file with comments | « Source/core/page/SpatialNavigation.cpp ('k') | Source/core/rendering/RenderImage.cpp » ('j') | no next file with comments »