Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1825073002: Revert[2] of "switch colorfilters to sk_sp (patchset #11 id:200001 of https://codereview.chromium.o… (Closed)

Created:
4 years, 9 months ago by reed1
Modified:
4 years, 9 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert[2] of "switch colorfilters to sk_sp (patchset #11 id:200001 of https://codereview.chromium.org/1822623002/ )" Fixed legacy withColorFilter to call new(er) make method This reverts commit 1eb81db650d31f50be67b12d60c4f9e7dd08432f. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1825073002 TBR= Committed: https://skia.googlesource.com/skia/+/4c9776b046dd5e9e46e2d1ce35154855c8fcb381

Patch Set 1 #

Patch Set 2 : test with guard #

Patch Set 3 : remove flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+423 lines, -458 lines) Patch
M bench/BlurRoundRectBench.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M bench/ColorCubeBench.cpp View 3 chunks +4 lines, -12 lines 0 comments Download
M bench/ColorFilterBench.cpp View 2 chunks +6 lines, -7 lines 0 comments Download
M bench/ImageFilterCollapse.cpp View 3 chunks +15 lines, -29 lines 0 comments Download
M gm/blurredclippedcircle.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M gm/blurroundrect.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M gm/color4f.cpp View 1 chunk +11 lines, -11 lines 0 comments Download
M gm/colorcube.cpp View 5 chunks +16 lines, -31 lines 0 comments Download
M gm/coloremoji.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M gm/colorfilterimagefilter.cpp View 5 chunks +17 lines, -20 lines 0 comments Download
M gm/colorfilters.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/colormatrix.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M gm/dropshadowimagefilter.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/emboss.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/fadefilter.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M gm/imagefilters.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/imagefiltersbase.cpp View 2 chunks +3 lines, -5 lines 0 comments Download
M gm/imagefilterscropexpand.cpp View 3 chunks +2 lines, -4 lines 0 comments Download
M gm/imagefilterscropped.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/imagefiltersgraph.cpp View 4 chunks +10 lines, -13 lines 0 comments Download
M gm/lumafilter.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M gm/megalooper.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M gm/modecolorfilters.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M gm/multipicturedraw.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/recordopts.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M gm/skbug1719.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/tablecolorfilter.cpp View 5 chunks +20 lines, -21 lines 0 comments Download
M gm/testimagefilters.cpp View 3 chunks +6 lines, -12 lines 0 comments Download
M gm/textbloblooper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/tileimagefilter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M gm/vertices.cpp View 3 chunks +14 lines, -14 lines 0 comments Download
M gyp/skia_for_android_framework_defines.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkColorFilter.h View 3 chunks +20 lines, -4 lines 0 comments Download
M include/core/SkPaint.h View 1 chunk +2 lines, -0 lines 0 comments Download
M include/core/SkShader.h View 1 2 chunks +2 lines, -4 lines 0 comments Download
M include/effects/SkBlurDrawLooper.h View 1 chunk +1 line, -1 line 0 comments Download
M include/effects/SkColorCubeFilter.h View 2 chunks +5 lines, -1 line 0 comments Download
M include/effects/SkColorFilterImageFilter.h View 1 chunk +1 line, -2 lines 0 comments Download
M include/effects/SkColorMatrixFilter.h View 1 chunk +13 lines, -8 lines 0 comments Download
M include/effects/SkLumaColorFilter.h View 1 chunk +5 lines, -1 line 0 comments Download
M include/effects/SkTableColorFilter.h View 2 chunks +15 lines, -3 lines 0 comments Download
M public.bzl View 2 chunks +3 lines, -1 line 0 comments Download
M samplecode/SampleAll.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M samplecode/SampleColorFilter.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M samplecode/SampleFilterFuzz.cpp View 5 chunks +15 lines, -22 lines 0 comments Download
M src/core/SkBlitter.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M src/core/SkCanvas.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M src/core/SkColorFilter.cpp View 4 chunks +18 lines, -16 lines 0 comments Download
M src/core/SkColorFilterShader.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/core/SkColorFilterShader.cpp View 2 chunks +12 lines, -12 lines 0 comments Download
M src/core/SkColorMatrixFilterRowMajor255.h View 2 chunks +3 lines, -4 lines 0 comments Download
M src/core/SkColorMatrixFilterRowMajor255.cpp View 2 chunks +8 lines, -6 lines 0 comments Download
M src/core/SkDevice.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/core/SkModeColorFilter.h View 1 chunk +6 lines, -1 line 0 comments Download
M src/core/SkModeColorFilter.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M src/core/SkPaint.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M src/core/SkReadBuffer.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/core/SkShader.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/effects/SkBlurDrawLooper.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M src/effects/SkColorCubeFilter.cpp View 2 chunks +9 lines, -9 lines 0 comments Download
M src/effects/SkColorFilterImageFilter.cpp View 3 chunks +7 lines, -11 lines 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkDropShadowImageFilter.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M src/effects/SkLayerDrawLooper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkLumaColorFilter.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M src/effects/SkTableColorFilter.cpp View 6 chunks +12 lines, -12 lines 0 comments Download
M src/pdf/SkPDFDevice.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M src/utils/SkLua.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/SkRGBAToYUV.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ColorFilterTest.cpp View 7 chunks +19 lines, -22 lines 0 comments Download
M tests/ColorMatrixTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/GpuColorFilterTest.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M tests/ImageFilterTest.cpp View 10 chunks +18 lines, -23 lines 0 comments Download
M tests/PaintTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/PictureTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/RecordOptsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/SerializationTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/SkColor4fTest.cpp View 4 chunks +11 lines, -14 lines 0 comments Download
M tools/android/SkAndroidSDKCanvas.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/debugger/SkDrawCommand.cpp View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825073002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825073002/40001
4 years, 9 months ago (2016-03-22 14:53:39 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/4c9776b046dd5e9e46e2d1ce35154855c8fcb381
4 years, 9 months ago (2016-03-22 15:10:21 UTC) #6
reed1
4 years, 9 months ago (2016-03-22 15:58:55 UTC) #7
Message was sent while issue was closed. 
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1821103004/ by reed@google.com.

The reason for reverting is: CreateModeFilter not compiling.

Powered by Google App Engine
This is Rietveld 408576698