src/utils/SkRGBAToYUV.cpp - Issue 1825073002: Revert[2] of "switch colorfilters to sk_sp (patchset #11 id:200001 of https://codereview.chromium.o…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/utils/SkRGBAToYUV.cpp

Issue 1825073002: Revert[2] of "switch colorfilters to sk_sp (patchset #11 id:200001 of https://codereview.chromium.o… (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: remove flag Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/utils/SkRGBAToYUV.cpp

diff --git a/src/utils/SkRGBAToYUV.cpp b/src/utils/SkRGBAToYUV.cpp

index b7f78bac14c08cc8110b0ca2935156d77b7ca2a1..eebbda4869e4baa4ce5914f2798c3060548732f1 100644

--- a/src/utils/SkRGBAToYUV.cpp

+++ b/src/utils/SkRGBAToYUV.cpp

@@ -49,7 +49,7 @@ bool SkRGBAToYUV(const SkImage* image, const SkISize sizes[3], void* const plane

int rowStartIdx = 5 * i;

const SkScalar* row = kYUVColorSpaceInvMatrices[colorSpace] + rowStartIdx;

paint.setColorFilter(

- SkColorMatrixFilterRowMajor255::CreateSingleChannelOutput(row))->unref();

+ SkColorMatrixFilterRowMajor255::MakeSingleChannelOutput(row));

surface->getCanvas()->drawImageRect(image, SkIRect::MakeWH(image->width(), image->height()),

SkRect::MakeIWH(surface->width(), surface->height()),

&paint);

« no previous file with comments | « src/utils/SkLua.cpp ('k') | tests/ColorFilterTest.cpp » ('j') | no next file with comments »