Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1825063003: depot_tools: remove code for --trybot-json (Closed)

Created:
4 years, 9 months ago by Paweł Hajdan Jr.
Modified:
4 years, 9 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

depot_tools: remove code for --trybot-json It was added in https://codereview.chromium.org/112503005 for https://bugs.chromium.org/p/chromium/issues/detail?id=278558 , but we ended up implementing the functionality in different way. BUG=583578 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299433

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -26 lines) Patch
M presubmit_support.py View 2 chunks +1 line, -26 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Paweł Hajdan Jr.
4 years, 9 months ago (2016-03-22 16:13:53 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825063003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825063003/1
4 years, 9 months ago (2016-03-22 16:14:47 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-22 16:17:19 UTC) #6
Sergiy Byelozyorov
lgtm
4 years, 9 months ago (2016-03-23 09:48:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825063003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825063003/1
4 years, 9 months ago (2016-03-23 09:50:35 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 09:52:53 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299433

Powered by Google App Engine
This is Rietveld 408576698