Issue 112503005: Have presubmit.py accept an option to output trybot data as json.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 112503005: Have presubmit.py accept an option to output trybot data as json. (Closed)

Created:
6 years, 11 months ago by ghost stip (do not use)

Modified:
6 years, 11 months ago

Reviewers:
iannucci, M-A Ruel

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Visibility:
Public.

More Reviews

Description

Have presubmit.py accept an option to output trybot data as json. BUG=278558 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=242918

Patch Set 2 : Address maruel's nits. #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -1 line)			Patch
	M	presubmit_support.py	View	1	3 chunks	+28 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ghost stip (do not use)

This is a WIP, while it works I'm still adding a test. PTAL

6 years, 11 months ago (2014-01-03 01:47:38 UTC) #1

M-A Ruel

lgtm https://codereview.chromium.org/112503005/diff/1/presubmit_support.py File presubmit_support.py (right): https://codereview.chromium.org/112503005/diff/1/presubmit_support.py#newcode9 presubmit_support.py:9: __version__ = '1.7.0' Bump https://codereview.chromium.org/112503005/diff/1/presubmit_support.py#newcode1466 presubmit_support.py:1466: return list(obj) ...

6 years, 11 months ago (2014-01-03 13:59:39 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stip@chromium.org/112503005/60001

6 years, 11 months ago (2014-01-03 20:12:39 UTC) #3

Message was sent while issue was closed.

Change committed as 242918

Expand Messages | Collapse Messages

Issue 112503005: Have presubmit.py accept an option to output trybot data as json. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address maruel's nits. #

Messages