Fix MenuController Gesture Crash

MenuController::OnGestureEvent can lead to menu closures. If a MenuDelegate were to delete the controller this can lead to a use_after_free error.

This change fixes that error, by setting the item_selected_by_touch_ flag before accepting taps. Which also correctly sets it for ExitMenuRun of async menus.

TEST=MenuControllerTest.AsynchronousGestureDeletesController
BUG=596688
Committed: https://crrev.com/0430b51ca87b2b8c0b7f076ee9834995f7cafaf7
Cr-Commit-Position: refs/heads/master@{#382862}

[jonross, 2016-03-23 00:21:21]

Patchset #1 (id:1) has been deleted

[jonross, 2016-03-23 00:25:46]

Description was changed from

==========
Fix MenuController Gesture Crash

BUG=
==========

to

==========
MenuController::OnGestureEvent can lead to menu closures. If a MenuDelegate were
to delete the controller this can lead to a use_after_free error.

This change fixes that error, by setting the item_selected_by_touch_ flag before
accepting taps. Which also correctly sets it for ExitMenuRun of async menus.

TEST=MenuControllerTest.AsynchronousGestureDeletesController
BUG=596688
==========

[jonross, 2016-03-23 00:26:43]

jonross@chromium.org changed reviewers:
+ sky@chromium.org

[jonross, 2016-03-23 00:26:43]

I've updated MenuController to address a use-after-free error.

PTAL

[sky, 2016-03-23 15:21:45]

LGTM

[jonross, 2016-03-23 15:28:50]

The CQ bit was checked by jonross@chromium.org

[commit-bot: I haz the power, 2016-03-23 15:28:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1824993003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1824993003/20001

[commit-bot: I haz the power, 2016-03-23 16:33:50]

Description was changed from

==========
MenuController::OnGestureEvent can lead to menu closures. If a MenuDelegate were
to delete the controller this can lead to a use_after_free error.

This change fixes that error, by setting the item_selected_by_touch_ flag before
accepting taps. Which also correctly sets it for ExitMenuRun of async menus.

TEST=MenuControllerTest.AsynchronousGestureDeletesController
BUG=596688
==========

to

==========
MenuController::OnGestureEvent can lead to menu closures. If a MenuDelegate were
to delete the controller this can lead to a use_after_free error.

This change fixes that error, by setting the item_selected_by_touch_ flag before
accepting taps. Which also correctly sets it for ExitMenuRun of async menus.

TEST=MenuControllerTest.AsynchronousGestureDeletesController
BUG=596688
==========

[commit-bot: I haz the power, 2016-03-23 16:33:51]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-03-23 16:35:16]

Description was changed from

==========
MenuController::OnGestureEvent can lead to menu closures. If a MenuDelegate were
to delete the controller this can lead to a use_after_free error.

This change fixes that error, by setting the item_selected_by_touch_ flag before
accepting taps. Which also correctly sets it for ExitMenuRun of async menus.

TEST=MenuControllerTest.AsynchronousGestureDeletesController
BUG=596688
==========

to

==========
MenuController::OnGestureEvent can lead to menu closures. If a MenuDelegate were
to delete the controller this can lead to a use_after_free error.

This change fixes that error, by setting the item_selected_by_touch_ flag before
accepting taps. Which also correctly sets it for ExitMenuRun of async menus.

TEST=MenuControllerTest.AsynchronousGestureDeletesController
BUG=596688

Committed: https://crrev.com/0430b51ca87b2b8c0b7f076ee9834995f7cafaf7
Cr-Commit-Position: refs/heads/master@{#382862}
==========

[commit-bot: I haz the power, 2016-03-23 16:35:17]

Patchset 1 (id:??) landed as
https://crrev.com/0430b51ca87b2b8c0b7f076ee9834995f7cafaf7
Cr-Commit-Position: refs/heads/master@{#382862}