ui/views/controls/menu/menu_controller.cc - Issue 1824993003: Fix MenuController Gesture Crash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/menu/menu_controller.cc

Issue 1824993003: Fix MenuController Gesture Crash (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/menu/menu_controller.cc

diff --git a/ui/views/controls/menu/menu_controller.cc b/ui/views/controls/menu/menu_controller.cc

index 7e0ba88d89e316c3458ca7aab66ab7615a757625..23c2e1bc81e58b46ce0e6a7045d654181d3e07d6 100644

--- a/ui/views/controls/menu/menu_controller.cc

+++ b/ui/views/controls/menu/menu_controller.cc

@@ -779,8 +779,8 @@ void MenuController::OnGestureEvent(SubmenuView* source,

!(part.menu->HasSubmenu())) {

if (part.menu->GetDelegate()->IsTriggerableEvent(

part.menu, *event)) {

- Accept(part.menu, event->flags());

item_selected_by_touch_ = true;

+ Accept(part.menu, event->flags());

}

event->StopPropagation();

} else if (part.type == MenuPart::MENU_ITEM) {

« no previous file with comments | « no previous file | ui/views/controls/menu/menu_controller_unittest.cc » ('j') | no next file with comments »