Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1291)

Unified Diff: content/browser/media/android/browser_media_player_manager.cc

Issue 182493003: enable subtitle support and the new fullscreen video (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: don't enable fullscreen subtitle for webview Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/android/browser_media_player_manager.cc
diff --git a/content/browser/media/android/browser_media_player_manager.cc b/content/browser/media/android/browser_media_player_manager.cc
index 1722403a5e18c739427473d0ddce250f3fd4f838..ca15dc8fce0a78654bf7d70387a42f067fd1a16c 100644
--- a/content/browser/media/android/browser_media_player_manager.cc
+++ b/content/browser/media/android/browser_media_player_manager.cc
@@ -188,8 +188,8 @@ void BrowserMediaPlayerManager::FullscreenPlayerSeek(int msec) {
}
void BrowserMediaPlayerManager::ExitFullscreen(bool release_media_player) {
- if (CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kEnableOverlayFullscreenVideoSubtitle)) {
+ if (!CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kDisableOverlayFullscreenVideoSubtitle)) {
if (WebContentsDelegate* delegate = web_contents_->GetDelegate())
delegate->ToggleFullscreenModeForTab(web_contents_, false);
if (RenderWidgetHostViewAndroid* view_android =
@@ -229,8 +229,8 @@ void BrowserMediaPlayerManager::SetVideoSurface(
}
player->SetVideoSurface(surface.Pass());
- if (!CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kEnableOverlayFullscreenVideoSubtitle)) {
+ if (CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kDisableOverlayFullscreenVideoSubtitle)) {
return;
}
if (RenderWidgetHostViewAndroid* view_android =

Powered by Google App Engine
This is Rietveld 408576698