content/browser/android/content_video_view.cc - Issue 182493003: enable subtitle support and the new fullscreen video

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/content_video_view.cc

Issue 182493003: enable subtitle support and the new fullscreen video (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: don't enable fullscreen subtitle for webview Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/android/content_video_view.cc

diff --git a/content/browser/android/content_video_view.cc b/content/browser/android/content_video_view.cc

index 0e6e090427b97234de80f90e11d0feb343b12b79..8623c5f8a4a872bcf9d1ba7aff66bfdfb4e11965 100644

--- a/content/browser/android/content_video_view.cc

+++ b/content/browser/android/content_video_view.cc

@@ -206,8 +206,8 @@ gfx::NativeView ContentVideoView::GetNativeView() {

JavaObjectWeakGlobalRef ContentVideoView::CreateJavaObject() {

ContentViewCoreImpl* content_view_core = manager_->GetContentViewCore();

JNIEnv* env = AttachCurrentThread();

- bool legacyMode = !CommandLine::ForCurrentProcess()->HasSwitch(

- switches::kEnableOverlayFullscreenVideoSubtitle);

+ bool legacyMode = CommandLine::ForCurrentProcess()->HasSwitch(

+ switches::kDisableOverlayFullscreenVideoSubtitle);

return JavaObjectWeakGlobalRef(

env,

Java_ContentVideoView_createContentVideoView(