Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 18247004: Cleanup the default Isolate's entry stack. (Closed)

Created:
7 years, 5 months ago by Benedikt Meurer
Modified:
7 years, 5 months ago
Reviewers:
danno, Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Cleanup the default Isolate's entry stack. This adds an ASSERT that the entry_stack_ of the Isolate is empty upon destruction. The default Isolate is an exception here, as it may still contain an entry stack item upon destruction. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15435

Patch Set 1 #

Total comments: 1

Patch Set 2 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M src/isolate.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
7 years, 5 months ago (2013-07-02 07:12:38 UTC) #1
Jakob Kummerow
LGTM with comment. https://codereview.chromium.org/18247004/diff/1/src/isolate.cc File src/isolate.cc (right): https://codereview.chromium.org/18247004/diff/1/src/isolate.cc#newcode1966 src/isolate.cc:1966: if (entry_stack_ != NULL) { You ...
7 years, 5 months ago (2013-07-02 07:15:02 UTC) #2
Benedikt Meurer
7 years, 5 months ago (2013-07-02 07:21:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r15435 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698