Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: src/isolate.cc

Issue 18247004: Cleanup the default Isolate's entry stack. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1942 matching lines...) Expand 10 before | Expand all | Expand 10 after
1953 void Isolate::SetIsolateThreadLocals(Isolate* isolate, 1953 void Isolate::SetIsolateThreadLocals(Isolate* isolate,
1954 PerIsolateThreadData* data) { 1954 PerIsolateThreadData* data) {
1955 Thread::SetThreadLocal(isolate_key_, isolate); 1955 Thread::SetThreadLocal(isolate_key_, isolate);
1956 Thread::SetThreadLocal(per_isolate_thread_data_key_, data); 1956 Thread::SetThreadLocal(per_isolate_thread_data_key_, data);
1957 } 1957 }
1958 1958
1959 1959
1960 Isolate::~Isolate() { 1960 Isolate::~Isolate() {
1961 TRACE_ISOLATE(destructor); 1961 TRACE_ISOLATE(destructor);
1962 1962
1963 // Cleanup entry stack for default isolate
1964 ASSERT(entry_stack_ == NULL || this == default_isolate_);
1965 ASSERT(entry_stack_ == NULL || entry_stack_->previous_item == NULL);
1966 if (entry_stack_ != NULL) {
Jakob Kummerow 2013/07/02 07:15:02 You don't need this condition; "delete" is safe to
1967 delete entry_stack_;
1968 entry_stack_ = NULL;
1969 }
1970
1963 delete[] assembler_spare_buffer_; 1971 delete[] assembler_spare_buffer_;
1964 assembler_spare_buffer_ = NULL; 1972 assembler_spare_buffer_ = NULL;
1965 1973
1966 delete unicode_cache_; 1974 delete unicode_cache_;
1967 unicode_cache_ = NULL; 1975 unicode_cache_ = NULL;
1968 1976
1969 delete date_cache_; 1977 delete date_cache_;
1970 date_cache_ = NULL; 1978 date_cache_ = NULL;
1971 1979
1972 delete[] code_stub_interface_descriptors_; 1980 delete[] code_stub_interface_descriptors_;
(...skipping 515 matching lines...) Expand 10 before | Expand all | Expand 10 after
2488 2496
2489 #ifdef DEBUG 2497 #ifdef DEBUG
2490 #define ISOLATE_FIELD_OFFSET(type, name, ignored) \ 2498 #define ISOLATE_FIELD_OFFSET(type, name, ignored) \
2491 const intptr_t Isolate::name##_debug_offset_ = OFFSET_OF(Isolate, name##_); 2499 const intptr_t Isolate::name##_debug_offset_ = OFFSET_OF(Isolate, name##_);
2492 ISOLATE_INIT_LIST(ISOLATE_FIELD_OFFSET) 2500 ISOLATE_INIT_LIST(ISOLATE_FIELD_OFFSET)
2493 ISOLATE_INIT_ARRAY_LIST(ISOLATE_FIELD_OFFSET) 2501 ISOLATE_INIT_ARRAY_LIST(ISOLATE_FIELD_OFFSET)
2494 #undef ISOLATE_FIELD_OFFSET 2502 #undef ISOLATE_FIELD_OFFSET
2495 #endif 2503 #endif
2496 2504
2497 } } // namespace v8::internal 2505 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698