Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1824693002: cros: Fix unexpected cryptohome failure UI (Closed)

Created:
4 years, 9 months ago by xiyuan
Modified:
4 years, 9 months ago
CC:
chromium-reviews, dzhioev+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Fix unexpected cryptohome failure UI TokenHandleFetcher::FillForNewUser should be called when there is no existing TokenHandle. Existing users should all go through the BackfillToken path. This would let the login screen code test against existing TokenHandle rather than racing with FillForNewUser code. BUG=596502 Committed: https://crrev.com/9231ba274a1c6525bf06cfc1a214fae2967663b7 Cr-Commit-Position: refs/heads/master@{#382342}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/chromeos/login/session/user_session_manager.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
xiyuan
4 years, 9 months ago (2016-03-21 18:11:58 UTC) #3
achuithb
lgtm
4 years, 9 months ago (2016-03-21 18:14:41 UTC) #5
xiyuan
Thanks for the quick review.
4 years, 9 months ago (2016-03-21 18:17:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1824693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1824693002/1
4 years, 9 months ago (2016-03-21 18:17:59 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-21 18:50:38 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 18:51:38 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9231ba274a1c6525bf06cfc1a214fae2967663b7
Cr-Commit-Position: refs/heads/master@{#382342}

Powered by Google App Engine
This is Rietveld 408576698