Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 1824623004: [Media Router WebUI] Update ESC handling. (Closed)

Created:
4 years, 9 months ago by apacible
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

[Media Router WebUI] Update ESC handling. ESC should be handled when pressed independently from other keys. Otherwise, we'll be overriding combinations such as shift+esc, which are keyboard shortcuts. BUG=592422 Review URL: https://codereview.chromium.org/1800213002 Cr-Commit-Position: refs/heads/master@{#381827} (cherry picked from commit 96b1b55fa2851c0dce144badc3e29c9b63e2fccd) Committed: https://chromium.googlesource.com/chromium/src/+/2b21b6a1daece0824b474b3507ed17cba680509d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -27 lines) Patch
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js View 3 chunks +24 lines, -19 lines 0 comments Download
M chrome/browser/resources/media_router/media_router.js View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
apacible
4 years, 9 months ago (2016-03-22 15:51:49 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2b21b6a1daece0824b474b3507ed17cba680509d.

Powered by Google App Engine
This is Rietveld 408576698