Issue 1824623004: [Media Router WebUI] Update ESC handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1824623004: [Media Router WebUI] Update ESC handling. (Closed)

Created:
4 years, 9 months ago by apacible

Modified:
4 years, 9 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2661

Target Ref:
refs/pending/branch-heads/2661

Project:
chromium

Visibility:
Public.

[Media Router WebUI] Update ESC handling. ESC should be handled when pressed independently from other keys. Otherwise, we'll be overriding combinations such as shift+esc, which are keyboard shortcuts. BUG=592422 Review URL: https://codereview.chromium.org/1800213002 Cr-Commit-Position: refs/heads/master@{#381827} (cherry picked from commit 96b1b55fa2851c0dce144badc3e29c9b63e2fccd) Committed: https://chromium.googlesource.com/chromium/src/+/2b21b6a1daece0824b474b3507ed17cba680509d

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -27 lines)			Patch
	M	chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js	View		3 chunks	+24 lines, -19 lines	0 comments	Download
	M	chrome/browser/resources/media_router/media_router.js	View		1 chunk	+0 lines, -8 lines	0 comments	Download

Total messages: 2 (1 generated)

apacible

4 years, 9 months ago (2016-03-22 15:51:49 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2b21b6a1daece0824b474b3507ed17cba680509d.