Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 1800213002: [Media Router WebUI] Update ESC handling. (Closed)

Created:
4 years, 9 months ago by apacible
Modified:
4 years, 9 months ago
Reviewers:
imcheng
CC:
chromium-reviews, media-router+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router WebUI] Update ESC handling. ESC should be handled when pressed independently from other keys. Otherwise, we'll be overriding combinations such as shift+esc, which are keyboard shortcuts. BUG=592422 Committed: https://crrev.com/96b1b55fa2851c0dce144badc3e29c9b63e2fccd Cr-Commit-Position: refs/heads/master@{#381827}

Patch Set 1 : #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -27 lines) Patch
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js View 1 3 chunks +24 lines, -19 lines 0 comments Download
M chrome/browser/resources/media_router/media_router.js View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
apacible
PTAL, thanks! Tested on mac and linux.
4 years, 9 months ago (2016-03-15 21:01:46 UTC) #5
imcheng
lgtm
4 years, 9 months ago (2016-03-17 18:26:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1800213002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1800213002/40001
4 years, 9 months ago (2016-03-17 22:09:51 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 9 months ago (2016-03-17 23:11:52 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 23:13:10 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/96b1b55fa2851c0dce144badc3e29c9b63e2fccd
Cr-Commit-Position: refs/heads/master@{#381827}

Powered by Google App Engine
This is Rietveld 408576698