Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 1824553004: Demote Mojo shell errors to warnings (Closed)

Created:
4 years, 9 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 9 months ago
Reviewers:
jam
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Demote Mojo shell errors to warnings Until we have application manifests sorted out in production these messages are too spammy to be errors. BUG=594419 R=jam@chromium.org Committed: https://crrev.com/07b3e034d356a9d3629a82041473d6db785a507d Cr-Commit-Position: refs/heads/master@{#382583}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M mojo/shell/shell.cc View 2 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ken Rockot(use gerrit already)
Can you take a look as mojo/ OWNER since ben is OOO?
4 years, 9 months ago (2016-03-21 21:04:55 UTC) #1
jam
lgtm
4 years, 9 months ago (2016-03-22 15:26:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1824553004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1824553004/1
4 years, 9 months ago (2016-03-22 15:51:24 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-22 16:29:17 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 16:30:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/07b3e034d356a9d3629a82041473d6db785a507d
Cr-Commit-Position: refs/heads/master@{#382583}

Powered by Google App Engine
This is Rietveld 408576698