Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1183)

Unified Diff: mojo/shell/shell.cc

Issue 1824553004: Demote Mojo shell errors to warnings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/shell/shell.cc
diff --git a/mojo/shell/shell.cc b/mojo/shell/shell.cc
index 1fb16b62795e4f3b52ce354f7316887f2ebecd09..c480e918d4e9ec94c7e9bdfeb49ae532f526c0c4 100644
--- a/mojo/shell/shell.cc
+++ b/mojo/shell/shell.cc
@@ -299,10 +299,10 @@ class Shell::Instance : public mojom::Connector,
const ConnectCallback& callback) {
if (!client_process_connection->is_null()) {
if (!HasClass(capability_spec_, kCapabilityClass_ClientProcess)) {
- LOG(ERROR) << "Error: Instance: " << identity_.name() << " attempting "
- << "to register an instance for a process it created for "
- << "target: " << target.name() << " without the "
- << "mojo:shell{client_process} capability class.";
+ LOG(WARNING) << "Instance: " << identity_.name() << " attempting "
+ << "to register an instance for a process it created for "
+ << "target: " << target.name() << " without the "
+ << "mojo:shell{client_process} capability class.";
callback.Run(mojom::ConnectResult::ACCESS_DENIED,
mojom::kInheritUserID, mojom::kInvalidInstanceID);
return false;
@@ -310,17 +310,17 @@ class Shell::Instance : public mojom::Connector,
if (!(*client_process_connection)->shell_client.is_valid() ||
!(*client_process_connection)->pid_receiver_request.is_valid()) {
- LOG(ERROR) << "Error: must supply both shell_client AND "
- << "pid_receiver_request when sending "
- << "client_process_connection.";
+ LOG(WARNING) << "Must supply both shell_client AND "
+ << "pid_receiver_request when sending "
+ << "client_process_connection.";
callback.Run(mojom::ConnectResult::INVALID_ARGUMENT,
mojom::kInheritUserID, mojom::kInvalidInstanceID);
return false;
}
if (shell_->GetExistingInstance(target)) {
- LOG(ERROR) << "Error: Cannot client process matching existing identity:"
- << "Name: " << target.name() << " User: " << target.user_id()
- << " Instance: " << target.instance();
+ LOG(WARNING) << "Cannot client process matching existing identity:"
+ << "Name: " << target.name() << " User: "
+ << target.user_id() << " Instance: " << target.instance();
callback.Run(mojom::ConnectResult::INVALID_ARGUMENT,
mojom::kInheritUserID, mojom::kInvalidInstanceID);
return false;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698