Change ShouldShowNoticeAboutOtherFormsOfBrowsingHistory to be asynchronous.

Change ShouldShowNoticeAboutOtherFormsOfBrowsingHistory to be asynchronous.

This is necessary, as we cannot get a response from WebHistoryService synchronously.

BUG=595332

[msramek, 2016-03-23 10:28:59]

msramek@chromium.org changed reviewers:
+ msarda@chromium.org

[msramek, 2016-03-23 10:29:00]

Hi Mihai,

I was going to start working on the WebHistoryService backend, when I realized
that we got the interface in history_notice_utils wrong - it must be
asynchronous :-/

We could also do a bit more - for example, make the UI an observer of a
singleton class in browsing_data_ui, that will in turn also observe changes in
ProfileSyncService and WebHistory, but I don't want to start overengineering
this now, so I think the solution in this CL should work.

Please have a look! Sorry for coming with this after you started to hook up this
method to your UI.

Best regards,
Martin

[msarda, 2016-03-23 10:35:42]

LGTM.

In my opinion, it would be good to have this be a part of the CL that does the
check in the history service to be 100% sure this in fact the right API.

https://codereview.chromium.org/1824333002/diff/1/components/browsing_data_ui...
File components/browsing_data_ui/history_notice_utils.cc (right):

https://codereview.chromium.org/1824333002/diff/1/components/browsing_data_ui...
components/browsing_data_ui/history_notice_utils.cc:13: bool
ShouldShowNoticeAboutOtherFormsOfBrowsingHistory(
Fix the return type.

[msramek, 2016-03-23 10:56:51]

Yes, that makes sense. My intention was to land a quick fix to make sure you're
not blocked, but let me actually do it together with the WebHistoryService
change. Shouldn't take too long.

https://codereview.chromium.org/1824333002/diff/1/components/browsing_data_ui...
File components/browsing_data_ui/history_notice_utils.cc (right):

https://codereview.chromium.org/1824333002/diff/1/components/browsing_data_ui...
components/browsing_data_ui/history_notice_utils.cc:13: bool
ShouldShowNoticeAboutOtherFormsOfBrowsingHistory(
On 2016/03/23 10:35:42, msarda wrote:
> Fix the return type.

Ah, yes. It linked successfully, because it's not called anywhere yet.

[msramek, 2016-03-23 15:47:20]

Closing this in favor of https://codereview.chromium.org/1829733002/.