Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Side by Side Diff: components/browsing_data_ui/history_notice_utils.cc

Issue 1824333002: Change ShouldShowNoticeAboutOtherFormsOfBrowsingHistory to be asynchronous. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Return value. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/browsing_data_ui/history_notice_utils.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/browsing_data_ui/history_notice_utils.h" 5 #include "components/browsing_data_ui/history_notice_utils.h"
6 6
7 #include "base/callback.h"
7 #include "components/browser_sync/browser/profile_sync_service.h" 8 #include "components/browser_sync/browser/profile_sync_service.h"
8 #include "components/history/core/browser/web_history_service.h" 9 #include "components/history/core/browser/web_history_service.h"
9 10
10 namespace browsing_data_ui { 11 namespace browsing_data_ui {
11 12
12 bool ShouldShowNoticeAboutOtherFormsOfBrowsingHistory( 13 void ShouldShowNoticeAboutOtherFormsOfBrowsingHistory(
13 const ProfileSyncService* sync_service, 14 const ProfileSyncService* sync_service,
14 const history::WebHistoryService* history_service) { 15 const history::WebHistoryService* history_service,
15 return sync_service && 16 base::Callback<void(bool)> callback) {
16 sync_service->IsSyncActive() && 17 // TODO(msramek): The asynchronicity is technically not needed here now,
17 !sync_service->IsUsingSecondaryPassphrase() && 18 // but when we change WebHistoryService::HasOtherFormsOfBrowsingHistory()
18 history_service && 19 // to communicate with the server, we will get the response asynchronously.
19 history_service->HasOtherFormsOfBrowsingHistory(); 20 // Therefore, we respond asynchronously here as well in anticipation of this
21 // change.
22 callback.Run(sync_service &&
23 sync_service->IsSyncActive() &&
24 !sync_service->IsUsingSecondaryPassphrase() &&
25 history_service &&
26 history_service->HasOtherFormsOfBrowsingHistory());
20 } 27 }
21 28
22 } // namespace browsing_data_ui 29 } // namespace browsing_data_ui
OLDNEW
« no previous file with comments | « components/browsing_data_ui/history_notice_utils.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698