Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1824233002: Fix black text on black background in <select> dialog. (Closed)

Created:
4 years, 9 months ago by newt (away)
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Fix black text on black background in <select> dialog. This happened when a <select> HTML element was used in WebView, and the activity containing the WebView had a pre-Holo theme (e.g. android:Theme.Black). BUG=596626 Review URL: https://codereview.chromium.org/1826573002 Cr-Commit-Position: refs/heads/master@{#382711} (cherry picked from commit 58873c3c518c096f1717ed5683963ae989e83ef8) Committed: https://chromium.googlesource.com/chromium/src/+/91765a3bc8ea02e419ea44897ceae4cc942d1875

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDialog.java View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
newt (away)
4 years, 9 months ago (2016-03-22 23:53:04 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
91765a3bc8ea02e419ea44897ceae4cc942d1875.

Powered by Google App Engine
This is Rietveld 408576698