Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1826573002: Fix black text on black background in <select> dialog. (Closed)

Created:
4 years, 9 months ago by newt (away)
Modified:
4 years, 9 months ago
Reviewers:
Ted C
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix black text on black background in <select> dialog. This happened when a <select> HTML element was used in WebView, and the activity containing the WebView had a pre-Holo theme (e.g. android:Theme.Black). BUG=596626 Committed: https://crrev.com/58873c3c518c096f1717ed5683963ae989e83ef8 Cr-Commit-Position: refs/heads/master@{#382711}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDialog.java View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
newt (away)
PTAL
4 years, 9 months ago (2016-03-22 20:56:27 UTC) #2
newt (away)
before/after screenshots on the bug
4 years, 9 months ago (2016-03-22 20:56:38 UTC) #3
Ted C
lgtm
4 years, 9 months ago (2016-03-22 21:01:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1826573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1826573002/1
4 years, 9 months ago (2016-03-22 21:17:56 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-22 22:26:45 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 22:28:53 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/58873c3c518c096f1717ed5683963ae989e83ef8
Cr-Commit-Position: refs/heads/master@{#382711}

Powered by Google App Engine
This is Rietveld 408576698