Retry errors setting executable headers.

Retry errors setting executable headers.

Fixes this flake: https://build.chromium.org/p/chromium.infra/builders/infra-continuous-mac-10.9-64/builds/1729/steps/upload%20go%20bin/logs/stdio

BUG=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299525

[dsansome, 2016-03-22 23:29:02]

dsansome@chromium.org changed reviewers:
+ tandrii@chromium.org

[tandrii(chromium), 2016-03-22 23:36:49]

tooo tired to review aom, but will do in the morning. But very appreciated.
While you are at it, can you also check for retries at actual upload?

[dsansome, 2016-03-22 23:54:13]

On 2016/03/22 23:36:49, tandrii(chromium) wrote:
> tooo tired to review aom, but will do in the morning. But very appreciated.
> While you are at it, can you also check for retries at actual upload?

gsutil cp promises to retry certain failures internally, but I've added an
overall retry for it anyway!

[tandrii(chromium), 2016-03-24 09:49:23]

tandrii@chromium.org changed reviewers:
+ hinoka@chromium.org

[tandrii(chromium), 2016-03-24 09:49:24]

me - lgtm, thanks for extra addition.
however, I'm not sure the extra is 100% OK to retry. I recommend to get hinoka@
opinion.

https://codereview.chromium.org/1824223002/diff/20001/download_from_google_st...
File download_from_google_storage.py (right):

https://codereview.chromium.org/1824223002/diff/20001/download_from_google_st...
download_from_google_storage.py:115: delay *= 1.3
nit: maybe self.DELAY_MULTIPLE then?

https://codereview.chromium.org/1824223002/diff/20001/upload_to_google_storag...
File upload_to_google_storage.py (right):

https://codereview.chromium.org/1824223002/diff/20001/upload_to_google_storag...
upload_to_google_storage.py:43: SET_EXECUTABLE_MAX_TRIES = 6
i think these are no longer neede.d

https://codereview.chromium.org/1824223002/diff/20001/upload_to_google_storag...
upload_to_google_storage.py:103: code, _, err =
gsutil.check_call_with_retries(*gsutil_args)
+hinoka@ I'm not sure retrying any non-0 code is a good idea. Could there be
some uploading error code that really shouldn't be retried?

[hinoka, 2016-03-24 11:28:54]

Worst case I think it just takes longer to fail, I think retrying (w/ backoff)
everywhere is probably okay.

https://codereview.chromium.org/1824223002/diff/20001/upload_to_google_storag...
File upload_to_google_storage.py (right):

https://codereview.chromium.org/1824223002/diff/20001/upload_to_google_storag...
upload_to_google_storage.py:103: code, _, err =
gsutil.check_call_with_retries(*gsutil_args)
On 2016/03/24 09:49:24, tandrii(chromium) wrote:
> +hinoka@ I'm not sure retrying any non-0 code is a good idea. Could there be
> some uploading error code that really shouldn't be retried?

In general I think if this one fails once, it might be permanent. But I could be
wrong and I don't see a huge detriment to retrying it anyways.

[dsansome, 2016-03-29 03:24:54]

https://codereview.chromium.org/1824223002/diff/20001/download_from_google_st...
File download_from_google_storage.py (right):

https://codereview.chromium.org/1824223002/diff/20001/download_from_google_st...
download_from_google_storage.py:115: delay *= 1.3
On 2016/03/24 09:49:24, tandrii(chromium)-OOO wrote:
> nit: maybe self.DELAY_MULTIPLE then?

Done.

https://codereview.chromium.org/1824223002/diff/20001/upload_to_google_storag...
File upload_to_google_storage.py (right):

https://codereview.chromium.org/1824223002/diff/20001/upload_to_google_storag...
upload_to_google_storage.py:43: SET_EXECUTABLE_MAX_TRIES = 6
On 2016/03/24 09:49:24, tandrii(chromium)-OOO wrote:
> i think these are no longer neede.d

Oops thanks

[dsansome, 2016-03-29 03:25:03]

The CQ bit was checked by dsansome@chromium.org

[dsansome, 2016-03-29 03:25:04]

The patchset sent to the CQ was uploaded after l-g-t-m from tandrii@chromium.org
Link to the patchset: https://codereview.chromium.org/1824223002/#ps40001
(title: "CL comments")

[commit-bot: I haz the power, 2016-03-29 03:25:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1824223002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1824223002/40001

[commit-bot: I haz the power, 2016-03-29 03:27:42]

Description was changed from

==========
Retry errors setting executable headers.

Fixes this flake:
https://build.chromium.org/p/chromium.infra/builders/infra-continuous-mac-10....

BUG=
==========

to

==========
Retry errors setting executable headers.

Fixes this flake:
https://build.chromium.org/p/chromium.infra/builders/infra-continuous-mac-10....

BUG=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299525
==========

[commit-bot: I haz the power, 2016-03-29 03:27:43]

Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299525