Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Unified Diff: upload_to_google_storage.py

Issue 1824223002: Retry errors setting executable headers. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: CL comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « download_from_google_storage.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: upload_to_google_storage.py
diff --git a/upload_to_google_storage.py b/upload_to_google_storage.py
index 4487457bdb2f8cba84203447f5cadeb8fcd39531..83f2f0e1648f74b92757858011844806b357b0d4 100755
--- a/upload_to_google_storage.py
+++ b/upload_to_google_storage.py
@@ -76,7 +76,7 @@ def _upload_worker(
file_url = '%s/%s' % (base_url, sha1_sum)
if gsutil.check_call('ls', file_url)[0] == 0 and not force:
# File exists, check MD5 hash.
- _, out, _ = gsutil.check_call('ls', '-L', file_url)
+ _, out, _ = gsutil.check_call_with_retries('ls', '-L', file_url)
etag_match = re.search('ETag:\s+([a-z0-9]{32})', out)
if etag_match:
remote_md5 = etag_match.group(1)
@@ -97,7 +97,7 @@ def _upload_worker(
if gzip:
gsutil_args.extend(['-z', gzip])
gsutil_args.extend([filename, file_url])
- code, _, err = gsutil.check_call(*gsutil_args)
+ code, _, err = gsutil.check_call_with_retries(*gsutil_args)
if code != 0:
ret_codes.put(
(code,
@@ -109,9 +109,9 @@ def _upload_worker(
# the download script will check for to preserve the executable bit.
if not sys.platform.startswith('win'):
if os.stat(filename).st_mode & stat.S_IEXEC:
- code, _, err = gsutil.check_call('setmeta', '-h',
- 'x-goog-meta-executable:1', file_url)
- if code:
+ code, _, err = gsutil.check_call_with_retries(
+ 'setmeta', '-h', 'x-goog-meta-executable:1', file_url)
+ if not code:
ret_codes.put(
(code,
'Encountered error on setting metadata on %s\n%s' %
« no previous file with comments | « download_from_google_storage.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698