Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 1824193002: Remove extra per-character walk in SVGTextLayoutEngine (Closed)

Created:
4 years, 9 months ago by pdr.
Modified:
4 years, 9 months ago
Reviewers:
fs
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove extra per-character walk in SVGTextLayoutEngine This patch removes a per-character walk in SVGTextLayoutEngine which was unnecessary because the glyph computation has the data available already. BUG=597076 Committed: https://crrev.com/f75cb329068c3768b2d4e6b0c0243795c81d1ae6 Cr-Commit-Position: refs/heads/master@{#382908}

Patch Set 1 #

Patch Set 2 : user interebase #

Patch Set 3 : Improve user interebase #

Patch Set 4 : Great Expectations #

Patch Set 5 : Greatest Expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -27 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 4 1 chunk +35 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp View 3 chunks +12 lines, -27 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
pdr.
We need to wait for the rebaselines from crbug.com/596721 to land first, but this is ...
4 years, 9 months ago (2016-03-22 22:28:21 UTC) #2
fs
On 2016/03/22 at 22:28:21, pdr wrote: > We need to wait for the rebaselines from ...
4 years, 9 months ago (2016-03-22 22:58:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1824193002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1824193002/40001
4 years, 9 months ago (2016-03-23 04:53:56 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/200750)
4 years, 9 months ago (2016-03-23 05:55:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1824193002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1824193002/60001
4 years, 9 months ago (2016-03-23 06:04:17 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/199341)
4 years, 9 months ago (2016-03-23 07:21:43 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1824193002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1824193002/80001
4 years, 9 months ago (2016-03-23 18:46:15 UTC) #16
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 9 months ago (2016-03-23 20:07:07 UTC) #17
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 20:09:50 UTC) #19
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/f75cb329068c3768b2d4e6b0c0243795c81d1ae6
Cr-Commit-Position: refs/heads/master@{#382908}

Powered by Google App Engine
This is Rietveld 408576698