third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.h - Issue 1824193002: Remove extra per-character walk in SVGTextLayoutEngine

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.h

Issue 1824193002: Remove extra per-character walk in SVGTextLayoutEngine (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Greatest Expectations Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.h

diff --git a/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.h b/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.h

index 9bafbfc430d495c7b636a133561ca69039330406..fc510dfec94e157245de711946e81e9649ba7a5b 100644

--- a/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.h

+++ b/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.h

@@ -62,6 +62,7 @@ private:

void updateCurrentTextPosition(float x, float y, float glyphAdvance);

void updateRelativePositionAdjustmentsIfNeeded(float dx, float dy);

+ void computeCurrentFragmentMetrics(SVGInlineTextBox*);

void recordTextFragment(SVGInlineTextBox*);

void beginTextPathLayout(SVGInlineFlowBox*);