Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1824143002: Link with imm32.lib. (Closed)

Created:
4 years, 9 months ago by jam
Modified:
4 years, 9 months ago
Reviewers:
scottmg
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Link with imm32.lib. Otherwise I'm seeing. [1/21] LINK(DLL) content.dll content.dll.lib FAILED: C:/python_27_amd64/files/python.exe gyp-win-tool link-wrapper environment.x86 False link.exe /nologo /IMPLIB:./content.dll.lib /DLL /OUT:./content.dll /PDB:./content.dll.pdb @./content.dll.rsp browser_main_runner.obj : error LNK2019: unresolved external symbol _ImmDisableTextFrameService@4 referenced in function "public: virtual in t __thiscall content::BrowserMainRunnerImpl::Initialize(struct content::MainFunctionParams const &)" (?Initialize@BrowserMainRunnerImpl@cont ent@@UAEHABUMainFunctionParams@2@@Z) ./content.dll : fatal error LNK1120: 1 unresolved externals ninja: build stopped: subcommand failed. This is caused by https://codereview.chromium.org/1813143002 which removed a file that had "#pragma comment(lib, "imm32.lib")" BUG=597028 Committed: https://crrev.com/6ce80494acfd8abf6f1164891cd8ff9487071304 Cr-Commit-Position: refs/heads/master@{#382696}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
jam
4 years, 9 months ago (2016-03-22 20:39:28 UTC) #2
scottmg
lgtm
4 years, 9 months ago (2016-03-22 20:44:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1824143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1824143002/1
4 years, 9 months ago (2016-03-22 20:51:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-22 22:00:29 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 22:01:44 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6ce80494acfd8abf6f1164891cd8ff9487071304
Cr-Commit-Position: refs/heads/master@{#382696}

Powered by Google App Engine
This is Rietveld 408576698