Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1813143002: Remove a bunch of NPAPI quirks and related support code (Closed)

Created:
4 years, 9 months ago by piman
Modified:
4 years, 9 months ago
Reviewers:
jam, dcheng
CC:
chromium-reviews, creis+watch_chromium.org, danakj+watch_chromium.org, darin-cc_chromium.org, jam, jbauman+watch_chromium.org, kalyank, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, nona+watch_chromium.org, piman+watch_chromium.org, shuchen+watch_chromium.org, sievers+watch_chromium.org, James Su, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove_windowed_plugins
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove a bunch of NPAPI quirks and related support code BUG=493212 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/f8396023a9e38d3ec249cdf1f730e4b79cebbc7e Cr-Commit-Position: refs/heads/master@{#382642} Committed: https://crrev.com/3e01508221503be4aa344a9e2d6e9e4596fe1a62 Cr-Commit-Position: refs/heads/master@{#382731}

Patch Set 1 : fix compile #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1791 lines) Patch
M content/browser/frame_host/render_widget_host_view_child_frame.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 2 chunks +0 lines, -10 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 2 chunks +0 lines, -43 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 chunks +2 lines, -13 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mus.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mus.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/child/BUILD.gn View 1 1 chunk +1 line, -5 lines 0 comments Download
M content/child/npapi/plugin_host.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M content/child/npapi/plugin_instance.h View 2 chunks +0 lines, -7 lines 0 comments Download
M content/child/npapi/plugin_instance.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/npapi/webplugin.h View 1 chunk +0 lines, -9 lines 0 comments Download
M content/child/npapi/webplugin_delegate_impl.h View 5 chunks +1 line, -98 lines 0 comments Download
M content/child/npapi/webplugin_delegate_impl_win.cc View 7 chunks +0 lines, -740 lines 0 comments Download
D content/child/npapi/webplugin_ime_win.h View 1 chunk +0 lines, -184 lines 0 comments Download
D content/child/npapi/webplugin_ime_win.cc View 1 chunk +0 lines, -314 lines 0 comments Download
M content/child/plugin_messages.h View 2 chunks +0 lines, -31 lines 0 comments Download
M content/common/plugin_constants_win.h View 2 chunks +0 lines, -10 lines 0 comments Download
M content/common/plugin_constants_win.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M content/common/view_messages.h View 1 chunk +0 lines, -8 lines 0 comments Download
M content/content_child.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/plugin/webplugin_delegate_stub.h View 1 chunk +0 lines, -7 lines 0 comments Download
M content/plugin/webplugin_delegate_stub.cc View 3 chunks +0 lines, -28 lines 0 comments Download
M content/plugin/webplugin_proxy.h View 2 chunks +0 lines, -12 lines 0 comments Download
M content/plugin/webplugin_proxy.cc View 2 chunks +0 lines, -26 lines 0 comments Download
M content/renderer/npapi/webplugin_delegate_proxy.h View 4 chunks +0 lines, -25 lines 0 comments Download
M content/renderer/npapi/webplugin_delegate_proxy.cc View 8 chunks +3 lines, -101 lines 0 comments Download
M content/renderer/npapi/webplugin_impl.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/renderer/render_view_impl.h View 2 chunks +1 line, -8 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 4 chunks +0 lines, -52 lines 0 comments Download
M content/test/test_render_view_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/test_render_view_host.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 31 (17 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1813143002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1813143002/40001
4 years, 9 months ago (2016-03-18 21:34:46 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/38013)
4 years, 9 months ago (2016-03-18 22:02:25 UTC) #7
piman
jam: please review dcheng: plugin_messages.h view_messages.h
4 years, 9 months ago (2016-03-19 00:38:49 UTC) #11
jam
lgtm
4 years, 9 months ago (2016-03-21 14:42:53 UTC) #12
piman
@dcheng: ping (just making sure it didn't fall through the cracks) - this blocks several ...
4 years, 9 months ago (2016-03-22 16:10:54 UTC) #13
dcheng
lgtm
4 years, 9 months ago (2016-03-22 16:16:41 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1813143002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1813143002/80001
4 years, 9 months ago (2016-03-22 16:58:28 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:80001)
4 years, 9 months ago (2016-03-22 19:37:53 UTC) #17
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f8396023a9e38d3ec249cdf1f730e4b79cebbc7e Cr-Commit-Position: refs/heads/master@{#382642}
4 years, 9 months ago (2016-03-22 19:39:31 UTC) #19
dgozman
A revert of this CL (patchset #1 id:80001) has been created in https://codereview.chromium.org/1825253002/ by dgozman@chromium.org. ...
4 years, 9 months ago (2016-03-22 21:31:00 UTC) #20
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1813143002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1813143002/100001
4 years, 9 months ago (2016-03-22 22:01:34 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1813143002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1813143002/100001
4 years, 9 months ago (2016-03-22 22:02:55 UTC) #27
commit-bot: I haz the power
Committed patchset #2 (id:100001)
4 years, 9 months ago (2016-03-22 23:38:45 UTC) #29
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 23:40:29 UTC) #31
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3e01508221503be4aa344a9e2d6e9e4596fe1a62
Cr-Commit-Position: refs/heads/master@{#382731}

Powered by Google App Engine
This is Rietveld 408576698