Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 1823863002: Simplify parsing/loading state, attempt #2 (Closed)

Created:
4 years, 9 months ago by Nate Chapin
Modified:
4 years, 9 months ago
Reviewers:
Mike West
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, gavinp+loader_chromium.org, Nate Chapin, kinuko+watch, loading-reviews+fetch_chromium.org, loading-reviews_chromium.org, rwlbuis, scheduler-bugs_chromium.org, sof, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify parsing/loading state, attempt #2 It seemed strange that DocumentLoader::stopLoading() both stops fetching via ResourceFetcher::stopFetching() and reports a cancellation via DocumentLoader::cancelMainResourceLoad(). Turns out, a lot of legacy logic is only needed to make that cancelMainResourceLoad() call work correctly. Replace it with a smaller, more container hack in FrameLoader::stopAllLoaders. BUG= Committed: https://crrev.com/243c3522db99d0a7d7174fc91ae0f0591eedd062 Cr-Commit-Position: refs/heads/master@{#382892}

Patch Set 1 : As reverted #

Total comments: 1

Patch Set 2 : Fixes #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -171 lines) Patch
M components/test_runner/web_test_proxy.cc View 1 1 chunk +1 line, -0 lines 1 comment Download
M third_party/WebKit/Source/core/dom/Document.h View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentParser.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/RawResource.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.h View 3 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp View 6 chunks +4 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLParserScheduler.h View 1 chunk +4 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLParserScheduler.cpp View 2 chunks +3 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentLoader.h View 4 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentLoader.cpp View 13 chunks +13 lines, -65 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 1 5 chunks +14 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/core/loader/NavigationScheduler.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823863002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823863002/20001
4 years, 9 months ago (2016-03-21 23:32:32 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-22 00:51:06 UTC) #5
Nate Chapin
If at first you don't succeed... https://codereview.chromium.org/1823863002/diff/1/third_party/WebKit/Source/core/loader/FrameLoader.cpp File third_party/WebKit/Source/core/loader/FrameLoader.cpp (right): https://codereview.chromium.org/1823863002/diff/1/third_party/WebKit/Source/core/loader/FrameLoader.cpp#newcode1029 third_party/WebKit/Source/core/loader/FrameLoader.cpp:1029: loadFailed(!m_documentLoader->sentDidFinishLoad() ? m_documentLoader.get() ...
4 years, 9 months ago (2016-03-22 16:42:43 UTC) #7
Mike West
*shrug* try try again? LGTM.
4 years, 9 months ago (2016-03-23 08:41:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823863002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823863002/20001
4 years, 9 months ago (2016-03-23 17:19:05 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-23 18:51:08 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 18:52:56 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/243c3522db99d0a7d7174fc91ae0f0591eedd062
Cr-Commit-Position: refs/heads/master@{#382892}

Powered by Google App Engine
This is Rietveld 408576698