third_party/WebKit/Source/core/loader/NavigationScheduler.cpp - Issue 1823863002: Simplify parsing/loading state, attempt #2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/NavigationScheduler.cpp

Issue 1823863002: Simplify parsing/loading state, attempt #2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/loader/NavigationScheduler.cpp

diff --git a/third_party/WebKit/Source/core/loader/NavigationScheduler.cpp b/third_party/WebKit/Source/core/loader/NavigationScheduler.cpp

index a5f2726d1f3c09eced3ec0130979a0b7a6841e2a..147c9a03f68fa910e7014840f0747d39f555c7f8 100644

--- a/third_party/WebKit/Source/core/loader/NavigationScheduler.cpp

+++ b/third_party/WebKit/Source/core/loader/NavigationScheduler.cpp

@@ -393,7 +393,7 @@ void NavigationScheduler::schedule(PassOwnPtrWillBeRawPtr<ScheduledNavigation> r

// FIXME: This check seems out of place.

if (!m_frame->loader().stateMachine()->committedFirstRealDocumentLoad() && m_frame->loader().provisionalDocumentLoader()) {

RefPtrWillBeRawPtr<LocalFrame> protect(m_frame.get());

- m_frame->loader().provisionalDocumentLoader()->stopLoading();

+ m_frame->loader().stopAllLoaders();

if (!m_frame->host())

return;

}