Take advantage of MojoGetBufferInformation

Take advantage of MojoGetBufferInformation

Now that we can ask a shared buffer what size it is before we map it, stop
explicitly passing the size across the media subsystem's MediaConsumer
interface.

BUG=
R=dalesat@chromium.org, viettrungluu@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/a4ace9188facd5865e145c566aac329b7b1b9f66

[johngro, 2016-03-22 00:45:39]

johngro@google.com changed reviewers:
+ dalesat@chromium.org, jeffbrown@google.com, viettrungluu@chromium.org

[viettrungluu, 2016-03-22 17:58:58]

LGTM apart from the stuff below and preferably with green trybots (not sure why
the patch didn't apply -- do you need to rebase?).

https://codereview.chromium.org/1823833003/diff/1/services/media/common/media...
File services/media/common/media_pipe_base.cc (right):

https://codereview.chromium.org/1823833003/diff/1/services/media/common/media...
services/media/common/media_pipe_base.cc:59: struct MojoBufferInformation info;
Up to you, but in most of our C++ code, we omit the |struct|.

https://codereview.chromium.org/1823833003/diff/1/services/media/common/media...
services/media/common/media_pipe_base.cc:64: }
|return;|?

[dalesat, 2016-03-22 18:15:55]

LGTM after Trung's comments are addressed.

[johngro, 2016-03-22 18:16:40]

re: trybots

I think that some of my changes in Dale's code to make git cl lint happy ended
up conflicting with a change he landed after I had sync'ed and rebased.

I rebased, and kdiff3 had no trouble figuring out the merge.  I'll make sure
that things are green before I pull the trigger.

https://codereview.chromium.org/1823833003/diff/1/services/media/common/media...
File services/media/common/media_pipe_base.cc (right):

https://codereview.chromium.org/1823833003/diff/1/services/media/common/media...
services/media/common/media_pipe_base.cc:59: struct MojoBufferInformation info;
On 2016/03/22 17:58:58, viettrungluu wrote:
> Up to you, but in most of our C++ code, we omit the |struct|.

Done.

https://codereview.chromium.org/1823833003/diff/1/services/media/common/media...
services/media/common/media_pipe_base.cc:64: }
On 2016/03/22 17:58:58, viettrungluu wrote:
> |return;|?

good catch!

[johngro, 2016-03-22 22:06:52]

Description was changed from

==========
Take advantage of MojoGetBufferInformation

Now that we can ask a shared buffer what size it is before we map it, stop
explicitly passing the size across the media subsystem's MediaConsumer
interface.

BUG=
==========

to

==========
Take advantage of MojoGetBufferInformation

Now that we can ask a shared buffer what size it is before we map it, stop
explicitly passing the size across the media subsystem's MediaConsumer
interface.

BUG=
R=dalesat@chromium.org, viettrungluu@chromium.org

Committed:
https://chromium.googlesource.com/external/mojo/+/a4ace9188facd5865e145c566aa...
==========

[johngro, 2016-03-22 22:06:53]

Committed patchset #3 (id:40001) manually as
a4ace9188facd5865e145c566aac329b7b1b9f66 (presubmit successful).