services/media/common/media_pipe_base.h - Issue 1823833003: Take advantage of MojoGetBufferInformation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/media/common/media_pipe_base.h

Issue 1823833003: Take advantage of MojoGetBufferInformation (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: rebase and fix a type mismatch which the android build caught Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/media/common/media_pipe_base.h

diff --git a/services/media/common/media_pipe_base.h b/services/media/common/media_pipe_base.h

index e5d3284cf1a90741dbf54a213829d232e56d4176..96c8afc8484f45da873d3ffe57945bfa47018e45 100644

--- a/services/media/common/media_pipe_base.h

+++ b/services/media/common/media_pipe_base.h

@@ -67,10 +67,10 @@ class MediaPipeBase : public MediaConsumer {

void* base() const { return base_; }

private:

- MappedSharedBuffer(ScopedSharedBufferHandle handle, size_t size);

+ MappedSharedBuffer(ScopedSharedBufferHandle handle, uint64_t size);

ScopedSharedBufferHandle handle_;

- size_t size_;

+ uint64_t size_;

void* base_ = nullptr;

};

@@ -85,7 +85,6 @@ class MediaPipeBase : public MediaConsumer {

// MediaConsumer.mojom implementation.

void SetBuffer(ScopedSharedBufferHandle handle,

- uint64_t size,

const SetBufferCallback& cbk) final;

void SendPacket(MediaPacketPtr packet,

const SendPacketCallback& cbk) final;