Create chrome://serviceworker-internals

content/browser/service_worker/service_worker_version.h

Index: content/browser/service_worker/service_worker_version.h
diff --git a/content/browser/service_worker/service_worker_version.h b/content/browser/service_worker/service_worker_version.h
index c577ac30c2c0d0271cbf83359a3df49a1da8888a..c1db27e6e8ad6ea8902a09e72d310ed79cfc5678 100644
--- a/content/browser/service_worker/service_worker_version.h
+++ b/content/browser/service_worker/service_worker_version.h
@@ -23,6 +23,7 @@ namespace content {
 
 class EmbeddedWorkerRegistry;
 class ServiceWorkerRegistration;
+class ServiceWorkerVersionInfo;
 struct ServiceWorkerFetchRequest;
 struct ServiceWorkerFetchResponse;
 
@@ -90,6 +91,8 @@ class CONTENT_EXPORT ServiceWorkerVersion
     return static_cast<Status>(embedded_worker_->status());
   }
 
+  static ServiceWorkerVersionInfo GetInfo(const ServiceWorkerVersion*);

[kinuko, 2014/03/05 03:43:20]

It feels having non-static method which takes ServiceWorkerVersionInfo* or
returns ServiceWorkerVersionInfo is more natural

void GetInfo(ServiceWorkerVersionInfo* info) const
ServiceWorkerVersionInfo GetInfo() const

[alecflett, 2014/03/05 21:41:20]

So I've adjusted it to be this way - it was this way to be able to account for a
null SWVersion (now the caller does instead)

+
   // Starts an embedded worker for this version.
   // This returns OK (success) if the worker is already running.
   void StartWorker(const StatusCallback& callback);
@@ -135,7 +138,9 @@ class CONTENT_EXPORT ServiceWorkerVersion
   void AddProcessToWorker(int process_id);
   void RemoveProcessToWorker(int process_id);
 
-  EmbeddedWorkerInstance* embedded_worker() { return embedded_worker_.get(); }
+  EmbeddedWorkerInstance* embedded_worker() const {
+    return embedded_worker_.get();

[kinuko, 2014/03/05 03:43:20]

nit: indent

Returning non-const ptr from const method is not very safe imho, do we need this
change? Is the only caller the GetInfo()?

[alecflett, 2014/03/05 21:41:20]

Yep.. I wonder if we could make embedded_worker_instance_ be const too, but I'll
leave that for another patch.

+  }
 
   // EmbeddedWorkerInstance::Observer overrides:
   virtual void OnStarted() OVERRIDE;