Create chrome://serviceworker-internals

content/browser/service_worker/service_worker_version.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_VERSION_H_
 #define CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_VERSION_H_
 
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/callback.h"
 #include "base/gtest_prod_util.h"
 #include "base/id_map.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "content/browser/service_worker/embedded_worker_instance.h"
 #include "content/common/content_export.h"
 #include "content/common/service_worker/service_worker_status_code.h"
 
 class GURL;
 
 namespace content {
 
 class EmbeddedWorkerRegistry;
 class ServiceWorkerRegistration;
+class ServiceWorkerVersionInfo;
 struct ServiceWorkerFetchRequest;
 struct ServiceWorkerFetchResponse;
 
 // This class corresponds to a specific version of a ServiceWorker
 // script for a given pattern. When a script is upgraded, there may be
 // more than one ServiceWorkerVersion "running" at a time, but only
 // one of them is active. This class connects the actual script with a
 // running worker.
 // Instances of this class are in one of two install states:
 // - Pending: The script is in the process of being installed. There
@@ skipping 47 matching lines @@
 
   int64 version_id() const { return version_id_; }
 
   void Shutdown();
   bool is_shutdown() const { return is_shutdown_; }
 
   Status status() const {
     return static_cast<Status>(embedded_worker_->status());
   }
 
+  static ServiceWorkerVersionInfo GetInfo(const ServiceWorkerVersion*);

[kinuko, 2014/03/05 03:43:20]

It feels having non-static method which takes ServiceWorkerVersionInfo* or
returns ServiceWorkerVersionInfo is more natural

void GetInfo(ServiceWorkerVersionInfo* info) const
ServiceWorkerVersionInfo GetInfo() const

[alecflett, 2014/03/05 21:41:20]

So I've adjusted it to be this way - it was this way to be able to account for a
null SWVersion (now the caller does instead)

+
   // Starts an embedded worker for this version.
   // This returns OK (success) if the worker is already running.
   void StartWorker(const StatusCallback& callback);
 
   // Starts an embedded worker for this version.
   // This returns OK (success) if the worker is already stopped.
   void StopWorker(const StatusCallback& callback);
 
   // Sends an IPC message to the worker.
   // If the worker is not running this first tries to start it by
@@ skipping 25 matching lines @@
   // |callback| with the response from the worker.
   void DispatchFetchEvent(const ServiceWorkerFetchRequest& request,
                           const FetchCallback& callback);
 
   // These are expected to be called when a renderer process host for the
   // same-origin as for this ServiceWorkerVersion is created.  The added
   // processes are used to run an in-renderer embedded worker.
   void AddProcessToWorker(int process_id);
   void RemoveProcessToWorker(int process_id);
 
-  EmbeddedWorkerInstance* embedded_worker() { return embedded_worker_.get(); }
+  EmbeddedWorkerInstance* embedded_worker() const {
+    return embedded_worker_.get();

[kinuko, 2014/03/05 03:43:20]

nit: indent

Returning non-const ptr from const method is not very safe imho, do we need this
change? Is the only caller the GetInfo()?

[alecflett, 2014/03/05 21:41:20]

Yep.. I wonder if we could make embedded_worker_instance_ be const too, but I'll
leave that for another patch.

+  }
 
   // EmbeddedWorkerInstance::Observer overrides:
   virtual void OnStarted() OVERRIDE;
   virtual void OnStopped() OVERRIDE;
   virtual void OnMessageReceived(int request_id,
                                  const IPC::Message& message) OVERRIDE;
 
  private:
   typedef ServiceWorkerVersion self;
   friend class base::RefCounted<ServiceWorkerVersion>;
@@ skipping 13 matching lines @@
   IDMap<MessageCallback, IDMapOwnPointer> message_callbacks_;
 
   base::WeakPtrFactory<ServiceWorkerVersion> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ServiceWorkerVersion);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_SERVICE_WORKER_SERVICE_WORKER_VERSION_H_