Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 182383006: Remove unfailable null checks in MediaControls (Closed)

Created:
6 years, 9 months ago by philipj_slow
Modified:
6 years, 9 months ago
CC:
blink-reviews, nessy, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium
Visibility:
Public.

Description

Remove unfailable null checks in MediaControls MediaControls::create returns null if any of these would be null. BUG=341813 R=acolwell@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168474

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -47 lines) Patch
M Source/core/html/shadow/MediaControls.cpp View 1 4 chunks +23 lines, -43 lines 0 comments Download
M Source/core/html/shadow/MediaControlsAndroid.cpp View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
philipj_slow
6 years, 9 months ago (2014-03-03 16:03:32 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm
6 years, 9 months ago (2014-03-04 01:27:41 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 9 months ago (2014-03-04 02:44:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/182383006/1
6 years, 9 months ago (2014-03-04 02:44:36 UTC) #4
philipj_slow
The CQ bit was unchecked by philipj@opera.com
6 years, 9 months ago (2014-03-04 16:04:39 UTC) #5
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 9 months ago (2014-03-04 18:13:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/182383006/1
6 years, 9 months ago (2014-03-04 18:13:55 UTC) #7
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 9 months ago (2014-03-05 07:10:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/182383006/20001
6 years, 9 months ago (2014-03-05 07:11:08 UTC) #9
philipj_slow
6 years, 9 months ago (2014-03-05 12:32:36 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 manually as r168474 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698