Issue 182383006: Remove unfailable null checks in MediaControls

Issue 182383006: Remove unfailable null checks in MediaControls (Closed)

Created:
6 years, 9 months ago by philipj_slow

Modified:
6 years, 9 months ago

Reviewers:
acolwell GONE FROM CHROMIUM

CC:
blink-reviews, nessy, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove unfailable null checks in MediaControls MediaControls::create returns null if any of these would be null. BUG=341813 R=acolwell@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168474

Patch Set 1 #

Patch Set 2 : rebase #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -47 lines)			Patch
	M	Source/core/html/shadow/MediaControls.cpp	View	1	4 chunks	+23 lines, -43 lines	0 comments	Download
	M	Source/core/html/shadow/MediaControlsAndroid.cpp	View		1 chunk	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/182383006/1

6 years, 9 months ago (2014-03-04 02:44:36 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/182383006/1

6 years, 9 months ago (2014-03-04 18:13:55 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/182383006/20001

6 years, 9 months ago (2014-03-05 07:11:08 UTC) #9

philipj_slow

6 years, 9 months ago (2014-03-05 12:32:36 UTC) #10

Message was sent while issue was closed.

Committed patchset #2 manually as r168474 (presubmit successful).

Expand Messages | Collapse Messages