Remove unfailable null checks in MediaControls

Source/core/html/shadow/MediaControls.cpp

 /*
  * Copyright (C) 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 133 matching lines @@
 
     return true;
 }
 
 void MediaControls::setMediaController(MediaControllerInterface* controller)
 {
     if (m_mediaController == controller)
         return;
     m_mediaController = controller;
 
-    if (m_panel)
-        m_panel->setMediaController(controller);
+    m_panel->setMediaController(controller);
     if (m_textDisplayContainer)
         m_textDisplayContainer->setMediaController(controller);
-    if (m_playButton)
-        m_playButton->setMediaController(controller);
-    if (m_currentTimeDisplay)
-        m_currentTimeDisplay->setMediaController(controller);
-    if (m_timeline)
-        m_timeline->setMediaController(controller);
-    if (m_panelMuteButton)
-        m_panelMuteButton->setMediaController(controller);
-    if (m_volumeSlider)
-        m_volumeSlider->setMediaController(controller);
-    if (m_toggleClosedCaptionsButton)
-        m_toggleClosedCaptionsButton->setMediaController(controller);
-    if (m_fullScreenButton)
-        m_fullScreenButton->setMediaController(controller);
-    if (m_durationDisplay)
-        m_durationDisplay->setMediaController(controller);
-    if (m_enclosure)
-        m_enclosure->setMediaController(controller);
+    m_playButton->setMediaController(controller);
+    m_currentTimeDisplay->setMediaController(controller);
+    m_timeline->setMediaController(controller);
+    m_panelMuteButton->setMediaController(controller);
+    m_volumeSlider->setMediaController(controller);
+    m_toggleClosedCaptionsButton->setMediaController(controller);
+    m_fullScreenButton->setMediaController(controller);
+    m_durationDisplay->setMediaController(controller);
+    m_enclosure->setMediaController(controller);
 }
 
 void MediaControls::reset()
 {
     Page* page = document().page();
     if (!page)
         return;
 
     double duration = m_mediaController->duration();
     m_durationDisplay->setInnerText(RenderTheme::theme().formatMediaControlsTime(duration), ASSERT_NO_EXCEPTION);
     m_durationDisplay->setCurrentValue(duration);
 
     m_playButton->updateDisplayType();
 
     updateCurrentTimeDisplay();
 
     m_timeline->setDuration(m_mediaController->duration());
     m_timeline->setPosition(m_mediaController->currentTime());
 
     m_panelMuteButton->show();
 
-    if (m_volumeSlider) {
-        if (!m_mediaController->hasAudio())
-            m_volumeSlider->hide();
-        else {
-            m_volumeSlider->show();
-            m_volumeSlider->setVolume(m_mediaController->volume());
-        }
+    if (!m_mediaController->hasAudio()) {
+        m_volumeSlider->hide();
+    } else {
+        m_volumeSlider->show();
+        m_volumeSlider->setVolume(m_mediaController->volume());
     }
 
     refreshClosedCaptionsButtonVisibility();
 
-    if (m_fullScreenButton) {
-        if (m_mediaController->hasVideo())
-            m_fullScreenButton->show();
-        else
-            m_fullScreenButton->hide();
-    }
+    if (m_mediaController->hasVideo())
+        m_fullScreenButton->show();
+    else
+        m_fullScreenButton->hide();
 
     makeOpaque();
 }
 
 void MediaControls::show()
 {
     makeOpaque();
     m_panel->setIsDisplayed(true);
     m_panel->show();
 }
@@ skipping 92 matching lines @@
     m_panelMuteButton->changedMute();
 
     if (m_mediaController->muted())
         m_volumeSlider->setVolume(0);
     else
         m_volumeSlider->setVolume(m_mediaController->volume());
 }
 
 void MediaControls::changedVolume()
 {
-    if (m_volumeSlider)
-        m_volumeSlider->setVolume(m_mediaController->volume());
-    if (m_panelMuteButton && m_panelMuteButton->renderer())
+    m_volumeSlider->setVolume(m_mediaController->volume());
+    if (m_panelMuteButton->renderer())
         m_panelMuteButton->renderer()->repaint();
 }
 
 void MediaControls::changedClosedCaptionsVisibility()
 {
-    if (m_toggleClosedCaptionsButton)
-        m_toggleClosedCaptionsButton->updateDisplayType();
+    m_toggleClosedCaptionsButton->updateDisplayType();
 }
 
 void MediaControls::refreshClosedCaptionsButtonVisibility()
 {
-    if (!m_toggleClosedCaptionsButton)
-        return;
-
     if (m_mediaController->hasClosedCaptions())
         m_toggleClosedCaptionsButton->show();
     else
         m_toggleClosedCaptionsButton->hide();
 }
 
 void MediaControls::closedCaptionTracksChanged()
 {
     refreshClosedCaptionsButtonVisibility();
 }
@@ skipping 96 matching lines @@
 }
 
 void MediaControls::createTextTrackDisplay()
 {
     if (m_textDisplayContainer)
         return;
 
     RefPtr<MediaControlTextTrackContainerElement> textDisplayContainer = MediaControlTextTrackContainerElement::create(document());
     m_textDisplayContainer = textDisplayContainer.get();
 
-    if (m_mediaController)
-        m_textDisplayContainer->setMediaController(m_mediaController);
+    m_textDisplayContainer->setMediaController(m_mediaController);
 
     insertTextTrackContainer(textDisplayContainer.release());
 }
 
 void MediaControls::showTextTrackDisplay()
 {
     if (!m_textDisplayContainer)
         createTextTrackDisplay();
     m_textDisplayContainer->show();
 }
@@ skipping 13 matching lines @@
     m_textDisplayContainer->updateDisplay();
 }
 
 void MediaControls::insertTextTrackContainer(PassRefPtr<MediaControlTextTrackContainerElement> textTrackContainer)
 {
     // Insert it before the first controller element so it always displays behind the controls.
     insertBefore(textTrackContainer, m_enclosure);
 }
 
 }