Oilpan: HTMLMediaElement should not dispatch event while document is being disposed.

Oilpan: HTMLMediaElement should not dispatch event while document is being disposed.

After haraken's change, Event is a heap-allocated object. Events should not be dispatched while document is being disposed.

BUG=None

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168346

[tkent, 2014-03-03 08:21:36]

Can you add a test?

[haraken, 2014-03-03 08:23:32]

The change looks good, but +1 to adding a test.

[kouhei (in TOK), 2014-03-03 08:38:51]

tkent,haraken: I agree we should have a test, but I couldn't come up with a test
case for this.

This is caused by Event having the last ref to Document being GC-ed. In that
case, Document::dispose() will detach the HTMLMediaElement in question, and this
|removedFrom()| will be called. The patch modifies the "if" condition so that it
won't trigger Event if document is being disposed.

[haraken, 2014-03-03 08:42:21]

On 2014/03/03 08:38:51, kouhei wrote:
> tkent,haraken: I agree we should have a test, but I couldn't come up with a
test
> case for this.
> 
> This is caused by Event having the last ref to Document being GC-ed. In that
> case, Document::dispose() will detach the HTMLMediaElement in question, and
this
> |removedFrom()| will be called. The patch modifies the "if" condition so that
it
> won't trigger Event if document is being disposed.

Thanks for the clarification. The issue happens only in an oilpan world where
Event destructors are delayed... Then it'd be hard to add a test in this CL.

LGTM. Please wait for kent-san's approval.

[tkent, 2014-03-03 09:30:27]

lgtm

[commit-bot: I haz the power, 2014-03-03 09:30:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kouhei@chromium.org/182383005/1

[commit-bot: I haz the power, 2014-03-03 12:11:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-03 12:11:10]

Retried try job too often on win_layout for step(s) webkit_lint
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[kouhei (in TOK), 2014-03-03 12:38:28]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2014-03-03 12:38:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kouhei@chromium.org/182383005/1

[commit-bot: I haz the power, 2014-03-03 15:40:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-03 15:40:50]

Retried try job too often on win_layout for step(s) webkit_lint
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout...

[kouhei (in TOK), 2014-03-04 00:40:23]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2014-03-04 00:41:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kouhei@chromium.org/182383005/1

[commit-bot: I haz the power, 2014-03-04 00:42:11]

Change committed as 168346