Source/core/html/HTMLMediaElement.cpp - Issue 182383005: Oilpan: HTMLMediaElement should not dispatch event while document is being disposed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLMediaElement.cpp

Issue 182383005: Oilpan: HTMLMediaElement should not dispatch event while document is being disposed. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLMediaElement.cpp

diff --git a/Source/core/html/HTMLMediaElement.cpp b/Source/core/html/HTMLMediaElement.cpp

index 5ced1f85324204fd73379398ccbe8b91242a42b3..e9197d5dd80e5a0dfbea8ee0c9d99392963ffc30 100644

--- a/Source/core/html/HTMLMediaElement.cpp

+++ b/Source/core/html/HTMLMediaElement.cpp

@@ -497,7 +497,7 @@ void HTMLMediaElement::removedFrom(ContainerNode* insertionPoint)

WTF_LOG(Media, "HTMLMediaElement::removedFrom");

m_active = false;

- if (insertionPoint->inDocument()) {

+ if (insertionPoint->inDocument() && insertionPoint->document().isActive()) {

configureMediaControls();

if (m_networkState > NETWORK_EMPTY)

pause();

« no previous file with comments | « no previous file | no next file » | no next file with comments »