Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1823813002: mojo leveldb: Add support to use in memory database. (Closed)

Created:
4 years, 9 months ago by Elliot Glaysher
Modified:
4 years, 9 months ago
Reviewers:
michaeln
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mojo leveldb: Add support to use in memory database. BUG=585587 Committed: https://crrev.com/900061b8d296c8b5bfc69a71bbb4cb87a20694d4 Cr-Commit-Position: refs/heads/master@{#382716}

Patch Set 1 #

Patch Set 2 : add memory read write unittest #

Total comments: 1

Patch Set 3 : how did i miss that... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -17 lines) Patch
M components/leveldb/leveldb_database_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/leveldb/leveldb_database_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/leveldb/leveldb_service_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/leveldb/leveldb_service_impl.cc View 2 chunks +22 lines, -0 lines 0 comments Download
M components/leveldb/leveldb_service_unittest.cc View 1 1 chunk +42 lines, -0 lines 0 comments Download
M components/leveldb/public/interfaces/leveldb.mojom View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/dom_storage/dom_storage_context_wrapper.cc View 1 2 1 chunk +18 lines, -14 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Elliot Glaysher
As requested in the previous patch.
4 years, 9 months ago (2016-03-22 18:09:18 UTC) #2
michaeln
lgtm (almost) https://codereview.chromium.org/1823813002/diff/20001/content/browser/dom_storage/dom_storage_context_wrapper.cc File content/browser/dom_storage/dom_storage_context_wrapper.cc (right): https://codereview.chromium.org/1823813002/diff/20001/content/browser/dom_storage/dom_storage_context_wrapper.cc#newcode134 content/browser/dom_storage/dom_storage_context_wrapper.cc:134: if (subdirectory_.empty()) { did you mean to ...
4 years, 9 months ago (2016-03-22 21:15:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823813002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823813002/40001
4 years, 9 months ago (2016-03-22 21:44:29 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-22 22:48:25 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 22:49:29 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/900061b8d296c8b5bfc69a71bbb4cb87a20694d4
Cr-Commit-Position: refs/heads/master@{#382716}

Powered by Google App Engine
This is Rietveld 408576698