Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1823723002: Move establish_channel_params.{cc|h} to content/gpu (Closed)

Created:
4 years, 9 months ago by Fady Samuel
Modified:
4 years, 9 months ago
Reviewers:
piman
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move establish_channel_params.{cc|h} to content/gpu This is a browser <=> gpu struct and so it really best belongs there. BUG=596290 Committed: https://crrev.com/27d230cc4675d3b25187e6a0c66b8a8c5f635451 Cr-Commit-Position: refs/heads/master@{#382354}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -91 lines) Patch
M content/browser/gpu/gpu_process_host.cc View 1 chunk +1 line, -0 lines 0 comments Download
D content/common/gpu/establish_channel_params.h View 1 chunk +0 lines, -27 lines 0 comments Download
D content/common/gpu/establish_channel_params.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M content/common/gpu/gpu_channel_manager.h View 2 chunks +6 lines, -2 lines 0 comments Download
M content/common/gpu/gpu_channel_manager.cc View 2 chunks +9 lines, -7 lines 0 comments Download
M content/common/gpu/gpu_channel_manager_unittest.cc View 3 chunks +12 lines, -19 lines 0 comments Download
M content/common/gpu/gpu_channel_unittest.cc View 2 chunks +3 lines, -8 lines 0 comments Download
M content/common/gpu/gpu_memory_uma_stats.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_common.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_gpu.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/gpu/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + content/gpu/establish_channel_params.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/gpu/establish_channel_params.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/gpu/gpu_child_thread.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/gpu/gpu_child_thread.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M content/gpu/gpu_host_messages.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
Fady Samuel
4 years, 9 months ago (2016-03-21 17:59:37 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823723002/1
4 years, 9 months ago (2016-03-21 17:59:59 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-21 19:03:32 UTC) #7
piman
lgtm
4 years, 9 months ago (2016-03-21 19:17:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823723002/1
4 years, 9 months ago (2016-03-21 19:18:09 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-21 19:25:15 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 19:27:55 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/27d230cc4675d3b25187e6a0c66b8a8c5f635451
Cr-Commit-Position: refs/heads/master@{#382354}

Powered by Google App Engine
This is Rietveld 408576698