Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: content/common/gpu/gpu_channel_manager_unittest.cc

Issue 1823723002: Move establish_channel_params.{cc|h} to content/gpu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/gpu/gpu_channel_manager.cc ('k') | content/common/gpu/gpu_channel_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/gpu/gpu_channel_manager_unittest.cc
diff --git a/content/common/gpu/gpu_channel_manager_unittest.cc b/content/common/gpu/gpu_channel_manager_unittest.cc
index 2938b8d304fb74cd013b9b7ffb9fd48332ee5f71..7c3cc0b3002c718841a93142206225786679094e 100644
--- a/content/common/gpu/gpu_channel_manager_unittest.cc
+++ b/content/common/gpu/gpu_channel_manager_unittest.cc
@@ -5,7 +5,6 @@
#include <stddef.h>
#include <stdint.h>
-#include "content/common/gpu/establish_channel_params.h"
#include "content/common/gpu/gpu_channel.h"
#include "content/common/gpu/gpu_channel_manager.h"
#include "content/common/gpu/gpu_channel_test_common.h"
@@ -30,14 +29,10 @@ TEST_F(GpuChannelManagerTest, EstablishChannel) {
ASSERT_TRUE(channel_manager());
- EstablishChannelParams params;
- params.client_id = kClientId;
- params.client_tracing_id = kClientTracingId;
- params.preempts = false;
- params.allow_view_command_buffers = false;
- params.allow_real_time_streams = false;
- IPC::ChannelHandle channel_handle =
- channel_manager()->EstablishChannel(params);
+ IPC::ChannelHandle channel_handle = channel_manager()->EstablishChannel(
+ kClientId, kClientTracingId, false /* preempts */,
+ false /* allow_view_command_buffers */,
+ false /* allow_real_time_streams */);
EXPECT_NE("", channel_handle.name);
GpuChannel* channel = channel_manager()->LookupChannel(kClientId);
@@ -64,19 +59,17 @@ TEST_F(GpuChannelManagerTest, SecureValueStateForwarding) {
ASSERT_TRUE(channel_manager());
// Initialize gpu channels
- EstablishChannelParams params;
- params.client_id = kClientId1;
- params.client_tracing_id = kClientTracingId1;
- params.preempts = false;
- params.allow_view_command_buffers = false;
- params.allow_real_time_streams = false;
- channel_manager()->EstablishChannel(params);
+ channel_manager()->EstablishChannel(kClientId1, kClientTracingId1,
+ false /* preempts */,
+ false /* allow_view_command_buffer */,
+ false /* allow_real_time_streams */);
GpuChannel* channel1 = channel_manager()->LookupChannel(kClientId1);
ASSERT_TRUE(channel1);
- params.client_id = kClientId2;
- params.client_tracing_id = kClientTracingId2;
- channel_manager()->EstablishChannel(params);
+ channel_manager()->EstablishChannel(kClientId2, kClientTracingId2,
+ false /* preempts */,
+ false /* allow_view_command_buffers */,
+ false /* allow_real_time_streams */);
GpuChannel* channel2 = channel_manager()->LookupChannel(kClientId2);
ASSERT_TRUE(channel2);
« no previous file with comments | « content/common/gpu/gpu_channel_manager.cc ('k') | content/common/gpu/gpu_channel_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698