Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 1823663003: Keep the list of active WorkerInspectorProxy objects. (Closed)

Created:
4 years, 9 months ago by dgozman
Modified:
4 years, 9 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, kinuko+worker_chromium.org, caseq+blink_chromium.org, lushnikov+blink_chromium.org, falken, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, horo+watch_chromium.org, sergeyv+blink_chromium.org, blink-worker-reviews_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Keep the list of active WorkerInspectorProxy objects. This removes the requirement of always instrumenting with InspectorWorkerAgent. Now agent can ask WorkerInspectorProxy about all the instances and connect to some of them when needed. The change will allow to construct worker agent lazily and move closer to inspector multi-client. BUG=590878 Committed: https://crrev.com/4c52adadab8a5b1455ffdf10cf258d3041e99c38 Cr-Commit-Position: refs/heads/master@{#382487}

Patch Set 1 #

Patch Set 2 : non-oilpan build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -73 lines) Patch
M third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.h View 2 chunks +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.cpp View 1 8 chunks +35 lines, -48 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerInspectorProxy.h View 3 chunks +11 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp View 4 chunks +40 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerMessagingProxy.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
dgozman
Take a look please.
4 years, 9 months ago (2016-03-21 21:34:35 UTC) #2
pfeldman
lgtm
4 years, 9 months ago (2016-03-21 23:56:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823663003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823663003/1
4 years, 9 months ago (2016-03-22 00:12:42 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_oilpan_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_blink_oilpan_rel/builds/19874)
4 years, 9 months ago (2016-03-22 00:27:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823663003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823663003/20001
4 years, 9 months ago (2016-03-22 01:16:16 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-22 02:59:42 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 03:02:12 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4c52adadab8a5b1455ffdf10cf258d3041e99c38
Cr-Commit-Position: refs/heads/master@{#382487}

Powered by Google App Engine
This is Rietveld 408576698