Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Unified Diff: third_party/WebKit/Source/core/workers/WorkerInspectorProxy.h

Issue 1823663003: Keep the list of active WorkerInspectorProxy objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: non-oilpan build Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/workers/WorkerInspectorProxy.h
diff --git a/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.h b/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.h
index 543539ab28e868198e55475f035f3402fa4858bd..fcbc0fe0eb1239be30357a65e22d3ea89370264c 100644
--- a/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.h
+++ b/third_party/WebKit/Source/core/workers/WorkerInspectorProxy.h
@@ -12,7 +12,7 @@
namespace blink {
-class ExecutionContext;
+class Document;
class KURL;
class WebTraceLocation;
class WorkerGlobalScopeProxy;
@@ -34,8 +34,8 @@ public:
virtual void workerConsoleAgentEnabled(WorkerInspectorProxy*) = 0;
};
- WorkerThreadStartMode workerStartMode(ExecutionContext*);
- void workerThreadCreated(ExecutionContext*, WorkerThread*, const KURL&);
+ WorkerThreadStartMode workerStartMode(Document*);
+ void workerThreadCreated(Document*, WorkerThread*, const KURL&);
void workerThreadTerminated();
void dispatchMessageFromWorker(const String&);
void workerConsoleAgentEnabled();
@@ -43,17 +43,23 @@ public:
void connectToInspector(PageInspector*);
void disconnectFromInspector(PageInspector*);
void sendMessageToInspector(const String&);
- void writeTimelineStartedEvent(const String& sessionId, const String& workerId);
+ void writeTimelineStartedEvent(const String& sessionId);
const String& url() { return m_url; }
+ Document* getDocument() { return m_document; }
+ const String& inspectorId();
+
+ using WorkerInspectorProxySet = WillBePersistentHeapHashSet<RawPtrWillBeWeakMember<WorkerInspectorProxy>>;
+ static const WorkerInspectorProxySet& allProxies();
private:
WorkerInspectorProxy();
WorkerThread* m_workerThread;
- RawPtrWillBeMember<ExecutionContext> m_executionContext;
+ RawPtrWillBeMember<Document> m_document;
PageInspector* m_pageInspector;
String m_url;
+ String m_inspectorId;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698