Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: components/leveldb/leveldb_apptest.cc

Issue 1823633002: Disabling flaky LevelDBApptest.(GetSnapshotSimple|Basic) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/leveldb/leveldb_apptest.cc
diff --git a/components/leveldb/leveldb_apptest.cc b/components/leveldb/leveldb_apptest.cc
index 2a99adcd3ed9731cc44f32bb6477ea0dae21700c..104c829400d2e526965a60c1c83b726761e66d8b 100644
--- a/components/leveldb/leveldb_apptest.cc
+++ b/components/leveldb/leveldb_apptest.cc
@@ -52,7 +52,13 @@ class LevelDBApptest : public mojo::test::ApplicationTestBase {
DISALLOW_COPY_AND_ASSIGN(LevelDBApptest);
};
-TEST_F(LevelDBApptest, Basic) {
+#if defined(OS_LINUX)
+// Flaky on Linux: http://crbug.com/594977,
+#define MAYBE_Basic DISABLED_Basic
+#else
+#define MAYBE_Basic Basic
+#endif
+TEST_F(LevelDBApptest, MAYBE_Basic) {
filesystem::DirectoryPtr directory;
GetUserDataDir(&directory);
@@ -268,6 +274,12 @@ TEST_F(LevelDBApptest, GetFromSnapshots) {
EXPECT_EQ("value", value.To<std::string>());
}
+#if defined(OS_LINUX)
+// Flaky on Linux: http://crbug.com/594977,
+#define MAYBE_InvalidArgumentOnInvalidSnapshot DISABLED_InvalidArgumentOnInvalidSnapshot
+#else
+#define MAYBE_InvalidArgumentOnInvalidSnapshot InvalidArgumentOnInvalidSnapshot
+#endif
TEST_F(LevelDBApptest, InvalidArgumentOnInvalidSnapshot) {
filesystem::DirectoryPtr directory;
GetUserDataDir(&directory);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698