Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Side by Side Diff: components/leveldb/leveldb_apptest.cc

Issue 1823633002: Disabling flaky LevelDBApptest.(GetSnapshotSimple|Basic) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/macros.h" 5 #include "base/macros.h"
6 #include "components/filesystem/public/interfaces/directory.mojom.h" 6 #include "components/filesystem/public/interfaces/directory.mojom.h"
7 #include "components/filesystem/public/interfaces/file_system.mojom.h" 7 #include "components/filesystem/public/interfaces/file_system.mojom.h"
8 #include "components/filesystem/public/interfaces/types.mojom.h" 8 #include "components/filesystem/public/interfaces/types.mojom.h"
9 #include "components/leveldb/public/interfaces/leveldb.mojom.h" 9 #include "components/leveldb/public/interfaces/leveldb.mojom.h"
10 #include "mojo/common/common_type_converters.h" 10 #include "mojo/common/common_type_converters.h"
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 filesystem::FileSystemPtr& files() { return files_; } 45 filesystem::FileSystemPtr& files() { return files_; }
46 LevelDBServicePtr& leveldb() { return leveldb_; } 46 LevelDBServicePtr& leveldb() { return leveldb_; }
47 47
48 private: 48 private:
49 filesystem::FileSystemPtr files_; 49 filesystem::FileSystemPtr files_;
50 LevelDBServicePtr leveldb_; 50 LevelDBServicePtr leveldb_;
51 51
52 DISALLOW_COPY_AND_ASSIGN(LevelDBApptest); 52 DISALLOW_COPY_AND_ASSIGN(LevelDBApptest);
53 }; 53 };
54 54
55 TEST_F(LevelDBApptest, Basic) { 55 #if defined(OS_LINUX)
56 // Flaky on Linux: http://crbug.com/594977,
57 #define MAYBE_Basic DISABLED_Basic
58 #else
59 #define MAYBE_Basic Basic
60 #endif
61 TEST_F(LevelDBApptest, MAYBE_Basic) {
56 filesystem::DirectoryPtr directory; 62 filesystem::DirectoryPtr directory;
57 GetUserDataDir(&directory); 63 GetUserDataDir(&directory);
58 64
59 DatabaseError error; 65 DatabaseError error;
60 LevelDBDatabasePtr database; 66 LevelDBDatabasePtr database;
61 leveldb()->Open(std::move(directory), "test", GetProxy(&database), 67 leveldb()->Open(std::move(directory), "test", GetProxy(&database),
62 Capture(&error)); 68 Capture(&error));
63 ASSERT_TRUE(leveldb().WaitForIncomingResponse()); 69 ASSERT_TRUE(leveldb().WaitForIncomingResponse());
64 EXPECT_EQ(DatabaseError::OK, error); 70 EXPECT_EQ(DatabaseError::OK, error);
65 71
(...skipping 195 matching lines...) Expand 10 before | Expand all | Expand 10 after
261 value.SetToEmpty(); 267 value.SetToEmpty();
262 database->GetFromSnapshot( 268 database->GetFromSnapshot(
263 key_value_snapshot, 269 key_value_snapshot,
264 mojo::Array<uint8_t>::From(std::string("key")), 270 mojo::Array<uint8_t>::From(std::string("key")),
265 Capture(&error, &value)); 271 Capture(&error, &value));
266 ASSERT_TRUE(database.WaitForIncomingResponse()); 272 ASSERT_TRUE(database.WaitForIncomingResponse());
267 EXPECT_EQ(DatabaseError::OK, error); 273 EXPECT_EQ(DatabaseError::OK, error);
268 EXPECT_EQ("value", value.To<std::string>()); 274 EXPECT_EQ("value", value.To<std::string>());
269 } 275 }
270 276
277 #if defined(OS_LINUX)
278 // Flaky on Linux: http://crbug.com/594977,
279 #define MAYBE_InvalidArgumentOnInvalidSnapshot DISABLED_InvalidArgumentOnInvalid Snapshot
280 #else
281 #define MAYBE_InvalidArgumentOnInvalidSnapshot InvalidArgumentOnInvalidSnapshot
282 #endif
271 TEST_F(LevelDBApptest, InvalidArgumentOnInvalidSnapshot) { 283 TEST_F(LevelDBApptest, InvalidArgumentOnInvalidSnapshot) {
272 filesystem::DirectoryPtr directory; 284 filesystem::DirectoryPtr directory;
273 GetUserDataDir(&directory); 285 GetUserDataDir(&directory);
274 286
275 LevelDBDatabasePtr database; 287 LevelDBDatabasePtr database;
276 DatabaseError error = DatabaseError::INVALID_ARGUMENT; 288 DatabaseError error = DatabaseError::INVALID_ARGUMENT;
277 leveldb()->Open(std::move(directory), "test", GetProxy(&database), 289 leveldb()->Open(std::move(directory), "test", GetProxy(&database),
278 Capture(&error)); 290 Capture(&error));
279 ASSERT_TRUE(leveldb().WaitForIncomingResponse()); 291 ASSERT_TRUE(leveldb().WaitForIncomingResponse());
280 EXPECT_EQ(DatabaseError::OK, error); 292 EXPECT_EQ(DatabaseError::OK, error);
281 293
282 uint64_t invalid_snapshot = 8; 294 uint64_t invalid_snapshot = 8;
283 295
284 error = DatabaseError::OK; 296 error = DatabaseError::OK;
285 mojo::Array<uint8_t> value; 297 mojo::Array<uint8_t> value;
286 database->GetFromSnapshot( 298 database->GetFromSnapshot(
287 invalid_snapshot, 299 invalid_snapshot,
288 mojo::Array<uint8_t>::From(std::string("key")), 300 mojo::Array<uint8_t>::From(std::string("key")),
289 Capture(&error, &value)); 301 Capture(&error, &value));
290 ASSERT_TRUE(database.WaitForIncomingResponse()); 302 ASSERT_TRUE(database.WaitForIncomingResponse());
291 EXPECT_EQ(DatabaseError::INVALID_ARGUMENT, error); 303 EXPECT_EQ(DatabaseError::INVALID_ARGUMENT, error);
292 } 304 }
293 305
294 } // namespace 306 } // namespace
295 } // namespace leveldb 307 } // namespace leveldb
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698